From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751157AbdEaOit (ORCPT ); Wed, 31 May 2017 10:38:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdEaOis (ORCPT ); Wed, 31 May 2017 10:38:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A6DCB66CA5 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vkuznets@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A6DCB66CA5 From: Vitaly Kuznetsov To: Stephen Hemminger Cc: x86@kernel.org, devel@linuxdriverproject.org, Stephen Hemminger , Jork Loeser , Haiyang Zhang , linux-kernel@vger.kernel.org, Steven Rostedt , Andy Shevchenko , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor References: <20170530113424.15687-1-vkuznets@redhat.com> <20170530113424.15687-3-vkuznets@redhat.com> <20170530095947.4cc19990@xeon-e3> Date: Wed, 31 May 2017 16:38:43 +0200 In-Reply-To: <20170530095947.4cc19990@xeon-e3> (Stephen Hemminger's message of "Tue, 30 May 2017 09:59:47 -0700") Message-ID: <877f0x147g.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 31 May 2017 14:38:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Hemminger writes: > On Tue, 30 May 2017 13:34:16 +0200 > Vitaly Kuznetsov wrote: > >> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c >> index 04cb8d3..bdcc433 100644 >> --- a/arch/x86/kernel/cpu/mshyperv.c >> +++ b/arch/x86/kernel/cpu/mshyperv.c >> @@ -175,9 +175,15 @@ static void __init ms_hyperv_init_platform(void) >> ms_hyperv.misc_features = cpuid_edx(HYPERV_CPUID_FEATURES); >> ms_hyperv.hints = cpuid_eax(HYPERV_CPUID_ENLIGHTMENT_INFO); >> >> - pr_info("HyperV: features 0x%x, hints 0x%x\n", >> + pr_info("Hyper-V: features 0x%x, hints 0x%x\n", >> ms_hyperv.features, ms_hyperv.hints); > >> >> + ms_hyperv.max_vp_index = cpuid_eax(HVCPUID_IMPLEMENTATION_LIMITS); >> + ms_hyperv.max_lp_index = cpuid_ebx(HVCPUID_IMPLEMENTATION_LIMITS); >> + >> + pr_info("Hyper-V: max %u virtual processors, %u logical processors\n", >> + ms_hyperv.max_vp_index, ms_hyperv.max_lp_index); >> + > > I understand as developer why you may need to log stuff. > Do we really need more logging here? Why not pr_debug()? Agreed, lets do pr_debug() instead. -- Vitaly