Re: [PATCH 3/6] gpio: dt-bindings: Add documentation for gpio controllers on Armada 7K/8K

Gregory CLEMENT
2017-05-31T10:06:06Z

Hi Rob,

On mer., mai 31 2017, Rob Herring <robh@kernel.org> wrote:
>>
>> Required properties:
>>
>> -- compatible : Should be "marvell,orion-gpio", "marvell,mv78200-gpio"
>> - or "marvell,armadaxp-gpio". "marvell,orion-gpio" should be used for
>> - Orion, Kirkwood, Dove, Discovery (except MV78200) and Armada
>> - 370. "marvell,mv78200-gpio" should be used for the Discovery
>> - MV78200. "marvel,armadaxp-gpio" should be used for all Armada XP
>> - SoCs (MV78230, MV78260, MV78460).
>> +- compatible : Should be "marvell,orion-gpio", "marvell,mv78200-gpio",
>> + "marvell,armadaxp-gpio" or "marvell,armada-8k-gpio".
>> +
>> + "marvell,orion-gpio" should be used for Orion, Kirkwood, Dove,
>> + Discovery (except MV78200) and Armada 370. "marvell,mv78200-gpio"
>> + should be used for the Discovery MV78200.
>> +
>> + "marvel,armadaxp-gpio" should be used for all Armada XP SoCs
>> + (MV78230, MV78260, MV78460).
>> +
>> + "marvell,armada-8k-gpio" should be used for the Armada 7K and 8K
>> + SoCs (either from AP or CP), see
>> + Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt
>> + and
>> + Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
>> + for specific details about the offset property.
>>
>> - reg: Address and length of the register set for the device. Only one
>> entry is expected, except for the "marvell,armadaxp-gpio" variant
>> for which two entries are expected: one for the general registers,
>> - one for the per-cpu registers.
>> + one for the per-cpu registers. Not used for marvell,armada-8k-gpio.
>
> Why can't use you use reg instead of offset?

I looked for how the other syscon user did, and I found the offset
usage. So I assumed it was the way to do it. But if you wan I can use a
reg property.

Gregory

>
> Rob

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.