* [PATCH] proc: Fix unbalanced hard link numbers
@ 2017-04-28 13:00 Takashi Iwai
2017-04-29 2:06 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Iwai @ 2017-04-28 13:00 UTC (permalink / raw)
To: Al Viro; +Cc: Eric W . Biederman, Andrew Morton, Tristan Ye, linux-kernel
proc_create_mount_point() forgot to increase the parent's nlink, and
it resulted in unbalanced hard link numbers, e.g. /proc/fs shows one
less than expected.
Fixes: eb6d38d5427b ("proc: Allow creating permanently empty directories...")
Cc: stable@vger.kernel.org
Reported-by: Tristan Ye <tristan.ye@suse.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
fs/proc/generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index ee27feb34cf4..9425c0d97262 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -472,6 +472,7 @@ struct proc_dir_entry *proc_create_mount_point(const char *name)
ent->data = NULL;
ent->proc_fops = NULL;
ent->proc_iops = NULL;
+ parent->nlink++;
if (proc_register(parent, ent) < 0) {
kfree(ent);
parent->nlink--;
--
2.12.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] proc: Fix unbalanced hard link numbers
2017-04-28 13:00 [PATCH] proc: Fix unbalanced hard link numbers Takashi Iwai
@ 2017-04-29 2:06 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2017-04-29 2:06 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Al Viro, Andrew Morton, Tristan Ye, linux-kernel
Takashi Iwai <tiwai@suse.de> writes:
> proc_create_mount_point() forgot to increase the parent's nlink, and
> it resulted in unbalanced hard link numbers, e.g. /proc/fs shows one
> less than expected.
Applied. Thanks.
>
> Fixes: eb6d38d5427b ("proc: Allow creating permanently empty directories...")
> Cc: stable@vger.kernel.org
> Reported-by: Tristan Ye <tristan.ye@suse.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> fs/proc/generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/proc/generic.c b/fs/proc/generic.c
> index ee27feb34cf4..9425c0d97262 100644
> --- a/fs/proc/generic.c
> +++ b/fs/proc/generic.c
> @@ -472,6 +472,7 @@ struct proc_dir_entry *proc_create_mount_point(const char *name)
> ent->data = NULL;
> ent->proc_fops = NULL;
> ent->proc_iops = NULL;
> + parent->nlink++;
> if (proc_register(parent, ent) < 0) {
> kfree(ent);
> parent->nlink--;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-29 2:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 13:00 [PATCH] proc: Fix unbalanced hard link numbers Takashi Iwai
2017-04-29 2:06 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox