From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760787AbdACTNR (ORCPT ); Tue, 3 Jan 2017 14:13:17 -0500 Received: from mga05.intel.com ([192.55.52.43]:52231 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757967AbdACTNI (ORCPT ); Tue, 3 Jan 2017 14:13:08 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,456,1477983600"; d="scan'208";a="918543809" From: Felipe Balbi To: Greg Kroah-Hartman , Aaro Koskinen Cc: Alan Stern , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing In-Reply-To: <20170103190504.GA10352@kroah.com> References: <20170102205355.18920-1-aaro.koskinen@iki.fi> <20170103165143.GA25272@kroah.com> <20170103185031.viic6w5tzshb7mt5@raspberrypi-2.musicnaut.iki.fi> <20170103190504.GA10352@kroah.com> Date: Tue, 03 Jan 2017 21:11:27 +0200 Message-ID: <877f6cm00w.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Greg Kroah-Hartman writes: > On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote: >> Hi, >> >> On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: >> > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: >> > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs >> > > to be loaded to get the PHY going and ohci-omap should wait for those. >> > > >> > > Signed-off-by: Aaro Koskinen >> > >> > Is this a new bug? The 770 has been around for forever, why has this >> > not been a problem before now? >> >> PHY/OTG support for 770 has been around only since v3.14. > > 3.14 was released March, 2014. A long time ago in kernel development :) > >> I was previously compiling phy-tahvo as built-in, and bumped into this >> issue when compiling it as a module. > > Why not just make the defconfig as built-in? > > I'm not objecting to this patch, just really curious why no one else has > ever hit it. Aaro is likely to be the last active OMAP1 user (let alone hacker) around. This is probably just a reflection of that fact. No-one else was using N770 with upstream (at least with USB in mind) :-) -- balbi