From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756170AbcJVVhQ (ORCPT ); Sat, 22 Oct 2016 17:37:16 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:44509 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755877AbcJVVhO (ORCPT ); Sat, 22 Oct 2016 17:37:14 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 22 Oct 2016 23:37:12 +0200 X-ME-IP: 92.136.207.250 From: Robert Jarzmik To: Viresh Kumar Cc: Daniel Mack , Haojian Zhuang , Rob Herring , Mark Rutland , Rafael Wysocki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API References: <1476561450-28407-1-git-send-email-robert.jarzmik@free.fr> <1476561450-28407-5-git-send-email-robert.jarzmik@free.fr> <20161018114025.GD11471@vireshk-i7> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 22 Oct 2016 23:37:09 +0200 In-Reply-To: <20161018114025.GD11471@vireshk-i7> (Viresh Kumar's message of "Tue, 18 Oct 2016 17:10:25 +0530") Message-ID: <877f902hh6.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Viresh Kumar writes: > On 15-10-16, 21:57, Robert Jarzmik wrote: >> As the clock settings have been introduced into the clock pxa drivers, >> which are now available to change the CPU clock by themselves, remove >> the clock handling from this driver, and rely on pxa clock drivers. >> >> Signed-off-by: Robert Jarzmik >> --- >> Since v1: added !OF Kconfig dependency >> --- >> drivers/cpufreq/Kconfig.arm | 2 +- >> drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++------------------------------- >> 2 files changed, 40 insertions(+), 153 deletions(-) > > Acked-by: Viresh Kumar Okay, after some more testing, I'd like to remove the !OF for next iteration. The reason is that I have a usecase where I have a single kernel image with devictree support (ie CONFIG_OF=y), but with support for both devicetree and legacy platforms. In this case, a platform such as lubbock can boot : - with devicetree - with legacy arch/arm/mach-pxa/lubbock.c In this kernel, the !OF Kconfig prevents the legacy version from working, as pxa2xx-cpufreq is descarded even if it is needed in the legacy version. Therefore, I'd like to respin without this !OF. Cheers. -- Robert