From: Felipe Balbi <balbi@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>,
Manish Narani <manish.narani@xilinx.com>
Cc: k.opasiak@samsung.com, r.baldyga@samsung.com,
peter.chen@freescale.com, mnarani@xilinx.com,
John.Youn@synopsys.com, eu@felipetonello.com,
i.kotrasinsk@samsung.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, anuragku@xilinx.com,
punnaia@xilinx.com
Subject: Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.
Date: Thu, 29 Sep 2016 15:23:39 +0300 [thread overview]
Message-ID: <877f9usxmc.fsf@linux.intel.com> (raw)
In-Reply-To: <20160929085405.GA8895@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
Hi,
Greg KH <gregkh@linuxfoundation.org> writes:
> On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote:
>> This patch adds support to configure bulk maxburst through
>> module parameter. This parameter can be used to modify bulk
>> maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT
>> performance.
>
> Eeek, this isn't the 1990's, please don't add new module parameters :)
>
> We have much better ways of handling configuration options for a device,
> why not use them (configfs, sysfs files, etc.)?
>
> Ugh, it looks like iso_maxburst is handled this way as well.
>
> Felipe, why is this?
Yeah, g_zero has a few module parameters. In fact many of the gadget
drivers have them. This is all legacy stuff, pre-configfs. We can't
simply remove the legacy gadget drivers and tell everybody to start
using configfs ;-) That's what we want, no doubt.
That being said, we're not taking any new module parameters to any of
the gadget drivers OR UDC drivers. Anything new is configfs-only. Legacy
gadgets only get bug fixes.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-09-29 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160929084701eucas1p2ca0b57d66f30f1aa5ec0825029990487@eucas1p2.samsung.com>
2016-09-29 8:46 ` [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero Manish Narani
2016-09-29 8:54 ` Greg KH
2016-09-29 12:23 ` Felipe Balbi [this message]
2016-09-30 11:12 ` Manish Narani
2016-09-29 8:58 ` Krzysztof Opasiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f9usxmc.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=anuragku@xilinx.com \
--cc=eu@felipetonello.com \
--cc=gregkh@linuxfoundation.org \
--cc=i.kotrasinsk@samsung.com \
--cc=k.opasiak@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mnarani@xilinx.com \
--cc=peter.chen@freescale.com \
--cc=punnaia@xilinx.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox