From: Felipe Balbi <balbi@kernel.org>
To: Romain Izard <romain.izard.pro@gmail.com>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Romain Izard <romain.izard.pro@gmail.com>
Subject: Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug
Date: Wed, 07 Sep 2016 13:44:49 +0300 [thread overview]
Message-ID: <877faokmzi.fsf@linux.intel.com> (raw)
In-Reply-To: <CAGkQfmOP+i1r-BAyCUebhfvU=zEBQ5ei0L5Sm0EaYMcpAGnFaw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
Romain Izard <romain.izard.pro@gmail.com> writes:
> 2016-08-29 11:07 GMT+02:00 Romain Izard <romain.izard.pro@gmail.com>:
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as debug, not as an error.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> v1 -> v2:
>> - use dev_dbg instead of dev_info
>>
>> drivers/usb/gadget/configfs.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index f9237fe2be05..3984787f8e97 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>>
>> list_move_tail(&f->list, &cfg->func_list);
>> if (f->unbind) {
>> - dev_err(&gi->cdev.gadget->dev, "unbind function"
>> - " '%s'/%p\n", f->name, f);
>> + dev_dbg(&gi->cdev.gadget->dev,
>> + "unbind function '%s'/%p\n",
>> + f->name, f);
>> f->unbind(c, f);
>> }
>> }
>> --
>> 2.7.4
>>
>
> Ping ?
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=da7b895d518cc1753ee5f4b7f2158087282d1a65
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
prev parent reply other threads:[~2016-09-07 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 16:21 [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard
2016-08-29 8:11 ` Romain Izard
2016-08-29 8:13 ` Felipe Balbi
2016-08-29 8:22 ` Romain Izard
2016-08-29 9:07 ` [PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard
2016-09-07 9:43 ` Romain Izard
2016-09-07 10:44 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877faokmzi.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox