From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992438AbcHRNqg (ORCPT ); Thu, 18 Aug 2016 09:46:36 -0400 Received: from mga03.intel.com ([134.134.136.65]:15918 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992419AbcHRNqe (ORCPT ); Thu, 18 Aug 2016 09:46:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,539,1464678000"; d="asc'?scan'208";a="157792675" From: Felipe Balbi To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Johan Hovold Subject: Re: [PATCH 3/3] USB: serial: use IS_ENABLED() instead of checking for built-in or module In-Reply-To: <1471527906-16604-3-git-send-email-javier@osg.samsung.com> References: <1471527906-16604-1-git-send-email-javier@osg.samsung.com> <1471527906-16604-3-git-send-email-javier@osg.samsung.com> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 16:46:17 +0300 Message-ID: <877fbe42c6.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Javier Martinez Canillas writes: > The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > built-in or as a module, use that macro instead of open coding the same. > > Using the macro makes the code more readable by helping abstract away some > of the Kconfig built-in and module enable details. > > Signed-off-by: Javier Martinez Canillas Assuming this is going through trivial tree: Acked-by: Felipe Balbi thanks > --- > > drivers/usb/serial/keyspan_pda.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspa= n_pda.c > index 4f7e072e4e00..e49ad0c63ad8 100644 > --- a/drivers/usb/serial/keyspan_pda.c > +++ b/drivers/usb/serial/keyspan_pda.c > @@ -30,12 +30,12 @@ > #include >=20=20 > /* make a simple define to handle if we are compiling keyspan_pda or xir= com support */ > -#if defined(CONFIG_USB_SERIAL_KEYSPAN_PDA) || defined(CONFIG_USB_SERIAL_= KEYSPAN_PDA_MODULE) > +#if IS_ENABLED(CONFIG_USB_SERIAL_KEYSPAN_PDA) > #define KEYSPAN > #else > #undef KEYSPAN > #endif > -#if defined(CONFIG_USB_SERIAL_XIRCOM) || defined(CONFIG_USB_SERIAL_XIRCO= M_MODULE) > +#if IS_ENABLED(CONFIG_USB_SERIAL_XIRCOM) > #define XIRCOM > #else > #undef XIRCOM > --=20 > 2.5.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtbwpAAoJEIaOsuA1yqREIJwQAIiJuRygX/L971s6iabBiHNa YYdD+XXEZZeKIe39dKSl3PluhT7u0GWgmA3gRV+iBXNYvXBEOApnLIbwUkClDPZY N3EfjKKxoYtRxIdUENgPNBOHOdD6sRhtK810N/qPPGepghmq+tdsecLqI5RI/omI j68X4XIP18DkEo9k6wlTwvSBJFganetLjdZc5YuaeM56vNL2AGGXRX0cYS1FeLQB 6xAsjgVtkE5kwxxnfrDEZyyurDCPhPpidtDQvjuVEFBF1UUH9dxuHPJtRzLMMi7G CCwx0npcK0hHLz2ZKyymkfhvLZ+waPkhfq59BQBw0C7zE/c8DuEhpS8smQEIi+JD kIpPLtH3n2VPQDx/Cp4f3Qa5mXXyOt6msdEM3Nm1csc5YPQ3qlQV3vDlScfMfLZ2 DbaC6fAC105MSptwN7x1OX5l/DJoaR67d7q7wJqRS/D3uxBnmRSgm6OB9+wce8XI 117s0IykBn8rSGPx68P+1+RQP9zAHGsQMS7hAfjRW2FjHVqtT0RBxsltlsSyp5zI 0tR433trGCh+qivgccOlrLu8qu5Uj6+5J+Z7+gItEUGidylVgHYyVm5zwoOvtLI0 4TAN0QAuhD+T9/Xmi9Go6MvMcIbh82rhaCjxiWZ7btoaALyRMIsRhkrG9+5v0AqE sp09jJTBxd8SSFg1SBQe =bsbj -----END PGP SIGNATURE----- --=-=-=--