From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbcGNUCb (ORCPT ); Thu, 14 Jul 2016 16:02:31 -0400 Received: from 36.223.133.77.rev.sfr.net ([77.133.223.36]:56858 "EHLO smtp.natisbad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbcGNUC2 (ORCPT ); Thu, 14 Jul 2016 16:02:28 -0400 From: arno@natisbad.org (Arnaud Ebalard) To: Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] rtc: ds1307: add Intersil ISL12057 support References: <1468371571-22641-1-git-send-email-alexandre.belloni@free-electrons.com> <1468371571-22641-3-git-send-email-alexandre.belloni@free-electrons.com> X-PGP-Key-URL: http://natisbad.org/arno@natisbad.org.asc X-Fingerprint: D3A5 B68A 839B 38A5 815A 781B B77C 0748 A7AE 341B X-Hashcash: 1:20:160714:a.zummo@towertech.it::kt02qbJkYvuyyer7:000000000000000000000000000000000000000000B8g X-Hashcash: 1:20:160714:alexandre.belloni@free-electrons.com::KM2DxzuBhOeF6ToG:00000000000000000000000000MZR X-Hashcash: 1:20:160714:rtc-linux@googlegroups.com::YMYWpY2fgvOPCD6g:000000000000000000000000000000000001CJA X-Hashcash: 1:20:160714:linux-kernel@vger.kernel.org::ZwXktMZ3kqFpvlXn:000000000000000000000000000000000AIK4 Date: Thu, 14 Jul 2016 21:57:07 +0200 In-Reply-To: <1468371571-22641-3-git-send-email-alexandre.belloni@free-electrons.com> (Alexandre Belloni's message of "Wed, 13 Jul 2016 02:59:30 +0200") Message-ID: <877fcohu24.fsf@natisbad.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexandre Belloni writes: > Intersil ISL12057 is a drop-in replacement for DS1337. It can be supported > by the ds1307 driver. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/Kconfig | 8 ++++---- > drivers/rtc/rtc-ds1307.c | 6 ++++++ > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index f47c2f5ff70d..ba0b3e7ce4c5 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -198,14 +198,14 @@ config RTC_DRV_AS3722 > will be called rtc-as3722. > > config RTC_DRV_DS1307 > - tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025" > + tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025, ISL12057" > help > If you say yes here you get support for various compatible RTC > chips (often with battery backup) connected with I2C. This driver > should handle DS1307, DS1337, DS1338, DS1339, DS1340, ST M41T00, > - EPSON RX-8025 and probably other chips. In some cases the RTC > - must already have been initialized (by manufacturing or a > - bootloader). > + EPSON RX-8025, Intersil ISL12057 and probably other chips. In some > + cases the RTC must already have been initialized (by manufacturing or > + a bootloader). > > The first seven registers on these chips hold an RTC, and other > registers may add features such as NVRAM, a trickle charger for > diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c > index 4c5890864d9c..52be48f2e3c0 100644 > --- a/drivers/rtc/rtc-ds1307.c > +++ b/drivers/rtc/rtc-ds1307.c > @@ -186,6 +186,7 @@ static const struct i2c_device_id ds1307_id[] = { > { "mcp7941x", mcp794xx }, > { "pt7c4338", ds_1307 }, > { "rx8025", rx_8025 }, > + { "isl1207", ds_1337 }, "isl12057"