From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Felipe Balbi <balbi@kernel.org>, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument
Date: Thu, 16 Jun 2016 19:56:38 +0200 [thread overview]
Message-ID: <877fdp9fvt.fsf@belgarion.home> (raw)
In-Reply-To: <20160616113831.4108439-5-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 16 Jun 2016 13:38:25 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> We get a warning for this when building with W=1 because the
> argument gets assigned to something else but never read:
>
> drivers/usb/gadget/udc/pxa27x_udc.c: In function 'stop_activity':
> drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: error: parameter 'driver' set but not used [-Werror=unused-but-set-parameter]
>
> This remove the argument entirely.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
I wonder if it'd worth adding this ... even if the word "Completes" would be more
correct than "Fixes" :
Fixes: 70189a63d408 ("usb: gadget: pxa27x_udc: convert to udc_start/udc_stop")
Apart form that:
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
next prev parent reply other threads:[~2016-06-16 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160616113831.4108439-1-arnd@arndb.de>
2016-06-16 11:38 ` [PATCH 1/5] net: qlcnic: don't set unused function argument Arnd Bergmann
2016-06-16 13:26 ` Rajesh Borundia
2016-06-17 0:33 ` David Miller
2016-06-16 11:38 ` [PATCH 2/5] net: tlan: " Arnd Bergmann
2016-06-17 0:33 ` David Miller
2016-06-16 11:38 ` [PATCH 3/5] mic: remove unused function arg Arnd Bergmann
2016-06-16 11:38 ` [PATCH 4/5] usb: pxa27x_udc: remove unused function argument Arnd Bergmann
2016-06-16 17:56 ` Robert Jarzmik [this message]
2016-06-16 11:38 ` [PATCH 5/5] fbmon: " Arnd Bergmann
2016-06-16 12:57 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fdp9fvt.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox