From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755226AbcFPR4q (ORCPT ); Thu, 16 Jun 2016 13:56:46 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:26106 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754094AbcFPR4o (ORCPT ); Thu, 16 Jun 2016 13:56:44 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 16 Jun 2016 19:56:42 +0200 X-ME-IP: 109.222.219.87 From: Robert Jarzmik To: Arnd Bergmann Cc: Felipe Balbi , Daniel Mack , Haojian Zhuang , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument References: <20160616113831.4108439-1-arnd@arndb.de> <20160616113831.4108439-5-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 16 Jun 2016 19:56:38 +0200 In-Reply-To: <20160616113831.4108439-5-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 16 Jun 2016 13:38:25 +0200") Message-ID: <877fdp9fvt.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > We get a warning for this when building with W=1 because the > argument gets assigned to something else but never read: > > drivers/usb/gadget/udc/pxa27x_udc.c: In function 'stop_activity': > drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: error: parameter 'driver' set but not used [-Werror=unused-but-set-parameter] > > This remove the argument entirely. > > Signed-off-by: Arnd Bergmann Hi Arnd, I wonder if it'd worth adding this ... even if the word "Completes" would be more correct than "Fixes" : Fixes: 70189a63d408 ("usb: gadget: pxa27x_udc: convert to udc_start/udc_stop") Apart form that: Acked-by: Robert Jarzmik Cheers. -- Robert