From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753879AbcD2Ozc (ORCPT ); Fri, 29 Apr 2016 10:55:32 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:53100 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836AbcD2Oza (ORCPT ); Fri, 29 Apr 2016 10:55:30 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: replace ds with ps where possible In-Reply-To: <20160429130645.GG4053@lunn.ch> References: <1461893046-28200-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20160429130645.GG4053@lunn.ch> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) Date: Fri, 29 Apr 2016 10:55:26 -0400 Message-ID: <877ffgmplt.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, Andrew Lunn writes: > On Thu, Apr 28, 2016 at 09:24:06PM -0400, Vivien Didelot wrote: >> From: Andrew Lunn >> >> The dsa_switch structure ds is actually needed in very few places, >> mostly during setup of the switch. The private structure ps is however >> needed nearly everywhere. Pass ps, not ds internally. >> >> [vd: rebased Andrew's patch.] > > Hi Vivien > > Thanks for picking up this patch and rebasing it. > > I would generally put comments like that bellow the ---. They don't > need to be in the commit log. I've seen that '[: ]' is often used to inject notes in the message, but that might not be a standard. Thanks for the note, Vivien