From: Felipe Balbi <balbi@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Baolin Wang <baolin.wang@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Peter Chen <peter.chen@freescale.com>,
Alan Stern <stern@rowland.harvard.edu>,
r.baldyga@samsung.com,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com,
Linux PM list <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
device-mainlining@lists.linuxfoundation.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework
Date: Mon, 18 Apr 2016 13:30:54 +0300 [thread overview]
Message-ID: <877ffvgqe9.fsf@intel.com> (raw)
In-Reply-To: <20160418102316.GA27936@amd>
[-- Attachment #1: Type: text/plain, Size: 2176 bytes --]
Hi,
Pavel Machek <pavel@ucw.cz> writes:
>> > Very often, you want to charge using 1.8A from an old desktop PC.
>>
>> if that old desktop's port is not a charging port, you shouldn't be
>> allowed to do that. Not ever.
>
> Yes, Felipe just decided that I should not be able to charge my N900
> in useful way.
you can do whatever you want with *your* kernel binary, but we're not
gonna ship something potentially dangerous. If that PC port is telling
you it can only allow 100mA, you should *not* be allowed to overcome
that limitation from the device side, sorry.
>> >> a) you are connected to a dedicated charger
>> >>
>> >> In this case, you can get up to 2000mA depending on the charger.
>> >>
>> >> If $this charger can give you or not 2000mA is not detectable,
>> >> so what do charging ICs do ? They slowly increase the attached
>> >> load accross VBUS/GND and measure VBUS value. When IC notices
>> >> VBUS dropping bit, step back to previous load.
>> >>
>> >> This means you will always charger with maximum rating of DCP.
>> >>
>> >> Why would user change this ? More is unsafe, less is just
>> >> stupid.
>> >
>> > Actually, less is not stupid. Charging li-ion battery from li-ion battery might
>> > be stupid. Imagine I'm on train, with device like N900 (50% battery) and power bank
>> > (3Ah). I'm actively using the device. If I let it charge at full current, I'll waste
>> > energy. If I limit current to approximately the power consumption, it will run the
>> > powerbank empty, first, then empty the internal battery, maximizing total time I
>> > can use the device.
>>
>> why would you waste energy ? What the charger chip would do is charge
>> battery to maximum then just to maintenance charge from that point
>> on. Where is energy being wasted other than normal heat dissipation ?
>
> Physics 101, of course wasted energy goes to heat. Lets not waste
> energy by charging li-ion from li-ion when it is not required.
your cellphone has no means to know that it's connected to a Li-Ion
battery. We don't have visibility on what we're connected to, just how
much it can source.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-04-18 10:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 11:46 [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2016-03-16 11:46 ` [PATCH v7 1/4] gadget: Introduce the usb charger framework Baolin Wang
2016-03-16 12:09 ` Oliver Neukum
2016-03-17 1:58 ` Baolin Wang
2016-03-30 10:09 ` Felipe Balbi
2016-03-30 17:44 ` Mark Brown
2016-03-31 6:21 ` Felipe Balbi
2016-03-31 6:28 ` Baolin Wang
2016-03-31 6:42 ` Felipe Balbi
2016-03-22 11:30 ` Pavel Machek
2016-04-18 8:12 ` Felipe Balbi
2016-04-18 10:23 ` Pavel Machek
2016-04-18 10:30 ` Felipe Balbi [this message]
2016-04-18 10:39 ` Pavel Machek
2016-04-18 10:49 ` Felipe Balbi
2016-04-18 10:55 ` Felipe Balbi
2016-04-18 11:13 ` Pavel Machek
2016-04-18 11:42 ` Felipe Balbi
2016-04-18 12:58 ` Pavel Machek
2016-04-18 13:34 ` Felipe Balbi
2016-04-18 10:59 ` David Laight
2016-04-18 11:23 ` Pavel Machek
2016-03-31 8:03 ` Baolin Wang
2016-03-22 11:29 ` Pavel Machek
2016-04-18 8:18 ` Felipe Balbi
2016-04-18 10:33 ` Pavel Machek
2016-04-18 10:45 ` Felipe Balbi
2016-04-18 11:03 ` Pavel Machek
2016-04-18 11:51 ` Felipe Balbi
2016-04-18 13:16 ` Pavel Machek
2016-04-18 13:30 ` Felipe Balbi
2016-03-31 8:18 ` Felipe Balbi
2016-03-31 8:35 ` Baolin Wang
2016-03-31 10:06 ` Felipe Balbi
2016-03-31 11:12 ` Baolin Wang
2016-03-31 17:06 ` Mark Brown
2016-04-01 5:43 ` Felipe Balbi
2016-04-01 14:16 ` Mark Brown
2016-04-04 10:47 ` Felipe Balbi
2016-04-04 16:04 ` Mark Brown
2016-04-04 18:44 ` Greg KH
2016-03-16 11:46 ` [PATCH v7 2/4] gadget: Support for " Baolin Wang
2016-03-16 12:50 ` kbuild test robot
2016-03-16 20:19 ` kbuild test robot
2016-03-16 11:46 ` [PATCH v7 3/4] gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang
2016-03-16 11:46 ` [PATCH v7 4/4] power: wm831x_power: Support USB charger current limit management Baolin Wang
2016-03-16 11:48 ` [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Felipe Balbi
2016-03-16 11:56 ` Baolin Wang
-- strict thread matches above, loose matches on Subject: below --
2016-01-04 3:04 Baolin Wang
2016-01-04 3:04 ` [PATCH v7 1/4] gadget: Introduce the usb charger framework Baolin Wang
2015-12-08 8:36 [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2015-12-08 8:36 ` [PATCH v7 1/4] gadget: Introduce the usb charger framework Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ffvgqe9.fsf@intel.com \
--to=balbi@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dbaryshkov@gmail.com \
--cc=device-mainlining@lists.linuxfoundation.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pavel@ucw.cz \
--cc=peter.chen@freescale.com \
--cc=r.baldyga@samsung.com \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).