From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbcBFVqH (ORCPT ); Sat, 6 Feb 2016 16:46:07 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:34063 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbcBFVqF (ORCPT ); Sat, 6 Feb 2016 16:46:05 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 06 Feb 2016 22:46:01 +0100 X-ME-IP: 109.222.219.121 From: Robert Jarzmik To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree References: <1454274354-4381-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 06 Feb 2016 22:46:00 +0100 In-Reply-To: <1454274354-4381-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sun, 31 Jan 2016 22:05:54 +0100") Message-ID: <877fih4inb.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > The initialization of interrupt controller for devicetree platform was > done for pxa2xx platforms, but not for pxa3xx ones. > > Fix this my adding the missing initialization call. > > Fixes: 089d03629b04 ("ARM: pxa: add devicetree code for irq handling") > Signed-off-by: Robert Jarzmik No, this is incorrect. The reason behind is that it relies on a patch not yet upstreamed, which was breaking exactly this init_irq. Let's drop this and replace it with the good patch. Cheers. -- Robert