From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbbJTEo0 (ORCPT ); Tue, 20 Oct 2015 00:44:26 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:47885 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbbJTEoZ (ORCPT ); Tue, 20 Oct 2015 00:44:25 -0400 Date: Tue, 20 Oct 2015 13:44:22 +0900 Message-ID: <877fmirvx5.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Daniel Lezcano Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, Alexey Klimov , uclinux-h8-devel@lists.sourceforge.jp (moderated list:H8/300 ARCHITECTURE) Subject: Re: [PATCH 5/9] clocksource/drivers/h8300_*: Remove unneeded memset()s In-Reply-To: <1445288368-6440-5-git-send-email-daniel.lezcano@linaro.org> References: <56255943.6060807@linaro.org> <1445288368-6440-1-git-send-email-daniel.lezcano@linaro.org> <1445288368-6440-5-git-send-email-daniel.lezcano@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2015 05:59:24 +0900, Daniel Lezcano wrote: > > From: Alexey Klimov > > Memory for timer16_priv, timer8_priv and tpu_priv structs is > allocated by devm_kzalloc() in corresponding probe functions > of drivers. > No need to zero it one more time. > > Signed-off-by: Alexey Klimov > Signed-off-by: Daniel Lezcano Acked-by: Yoshinori Sato > --- > drivers/clocksource/h8300_timer16.c | 1 - > drivers/clocksource/h8300_timer8.c | 1 - > drivers/clocksource/h8300_tpu.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/clocksource/h8300_timer16.c b/drivers/clocksource/h8300_timer16.c > index 82941c1..0e076c6 100644 > --- a/drivers/clocksource/h8300_timer16.c > +++ b/drivers/clocksource/h8300_timer16.c > @@ -153,7 +153,6 @@ static int timer16_setup(struct timer16_priv *p, struct platform_device *pdev) > int ret, irq; > unsigned int ch; > > - memset(p, 0, sizeof(*p)); > p->pdev = pdev; > > res[REG_CH] = platform_get_resource(p->pdev, > diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c > index f9b3b70..44375d8 100644 > --- a/drivers/clocksource/h8300_timer8.c > +++ b/drivers/clocksource/h8300_timer8.c > @@ -215,7 +215,6 @@ static int timer8_setup(struct timer8_priv *p, > int irq; > int ret; > > - memset(p, 0, sizeof(*p)); > p->pdev = pdev; > > res = platform_get_resource(p->pdev, IORESOURCE_MEM, 0); > diff --git a/drivers/clocksource/h8300_tpu.c b/drivers/clocksource/h8300_tpu.c > index 64195fd..5487410 100644 > --- a/drivers/clocksource/h8300_tpu.c > +++ b/drivers/clocksource/h8300_tpu.c > @@ -123,7 +123,6 @@ static int __init tpu_setup(struct tpu_priv *p, struct platform_device *pdev) > { > struct resource *res[2]; > > - memset(p, 0, sizeof(*p)); > p->pdev = pdev; > > res[CH_L] = platform_get_resource(p->pdev, IORESOURCE_MEM, CH_L); > -- > 1.9.1 >