From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754125AbbI3Oco (ORCPT ); Wed, 30 Sep 2015 10:32:44 -0400 Received: from mga09.intel.com ([134.134.136.24]:27980 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753699AbbI3Ocl convert rfc822-to-8bit (ORCPT ); Wed, 30 Sep 2015 10:32:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,612,1437462000"; d="scan'208";a="816267328" From: Jani Nikula To: Geliang Tang , Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915: fix compiler warnings in intel_audio.c In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: User-Agent: Notmuch/0.20.2+101~gb57168b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 30 Sep 2015 17:35:59 +0300 Message-ID: <877fn8c6uo.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Geliang Tang wrote: > Fix the following warnings: > > CC drivers/gpu/drm/i915/intel_audio.o > drivers/gpu/drm/i915/intel_audio.c: In function ‘hsw_audio_codec_enable’: > drivers/gpu/drm/i915/intel_audio.c:332:39: warning: passing argument 2 of ‘audio_rate_need_prog’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > if (audio_rate_need_prog(intel_crtc, adjusted_mode)) { > ^ > drivers/gpu/drm/i915/intel_audio.c:147:13: note: expected ‘struct drm_display_mode *’ but argument is of type ‘const struct drm_display_mode *’ > static bool audio_rate_need_prog(struct intel_crtc *crtc, > ^ Already fixed by Takashi: http://mid.gmane.org/1443599103-26317-1-git-send-email-tiwai@suse.de Thanks anyway, Jani. > > Signed-off-by: Geliang Tang > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c > index baadd90..72d696b 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -145,7 +145,7 @@ static uint32_t audio_config_setup_n_reg(int n, uint32_t val) > > /* check whether N/CTS/M need be set manually */ > static bool audio_rate_need_prog(struct intel_crtc *crtc, > - struct drm_display_mode *mode) > + const struct drm_display_mode *mode) > { > if (((mode->clock == TMDS_297M) || > (mode->clock == TMDS_296M)) && > -- > 2.5.0 > > -- Jani Nikula, Intel Open Source Technology Center