From: Jakub Sitnicki <jsitnicki@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants
Date: Sat, 25 Jul 2015 16:05:52 +0200 [thread overview]
Message-ID: <877fpo8hbm.fsf@frog.home> (raw)
In-Reply-To: <20150724203952.GA27809@kroah.com>
On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote:
>> linux/ieee80211.h already defines constants for information element IDs.
>> Include it where needed, resolve discrepancies in naming, and remove the
>> duplicated definitions.
>>
>> While at it, wrap a line that was too long and remove extra parentheses
>> in an expression that mixes only equality and logical operators.
>
> This patch doesn't apply at all.
My mistake, sorry. I've generated it against v4.2-rc3.
> Also, don't do more than one thing in a single patch, this should be
> broken up into multiple ones.
OK, I'll redo it with style fixes split out into a separate patch.
Cheers,
Jakub
next prev parent reply other threads:[~2015-07-25 14:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 5:23 [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants Jakub Sitnicki
2015-07-23 18:11 ` Jakub Sitnicki
2015-07-23 18:37 ` Greg Kroah-Hartman
2015-07-24 15:12 ` [PATCH RESEND] " Jakub Sitnicki
2015-07-24 20:39 ` Greg Kroah-Hartman
2015-07-25 14:05 ` Jakub Sitnicki [this message]
2015-07-25 14:30 ` Dan Carpenter
2015-07-25 21:24 ` Jakub Sitnicki
2015-07-29 8:15 ` [PATCH v2 0/4] staging: rtl8188eu: clean up duplicated WLAN_* constants Jakub Sitnicki
2015-07-29 8:15 ` [PATCH v2 1/4] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants Jakub Sitnicki
2015-07-29 8:15 ` [PATCH v2 2/4] staging: rtl8188eu: wrap a long if condition and remove extra parenthesis Jakub Sitnicki
2015-07-29 8:15 ` [PATCH v2 3/4] staging: rtl8188eu: don't duplicate ieee80211 WLAN_AUTH_* constants Jakub Sitnicki
2015-07-29 8:15 ` [PATCH v2 4/4] staging: rtl8188eu: don't duplicate ieee80211 WLAN_HT_CAP_SM_PS_* constants Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fpo8hbm.fsf@frog.home \
--to=jsitnicki@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox