From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754938AbbGYOGA (ORCPT ); Sat, 25 Jul 2015 10:06:00 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37501 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754750AbbGYOF7 (ORCPT ); Sat, 25 Jul 2015 10:05:59 -0400 References: <20150723183707.GB29830@kroah.com> <1437750758-17120-1-git-send-email-jsitnicki@gmail.com> <20150724203952.GA27809@kroah.com> From: Jakub Sitnicki To: Greg Kroah-Hartman Cc: Larry Finger , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants Message-ID: <877fpo8hbm.fsf@frog.home> In-reply-to: <20150724203952.GA27809@kroah.com> Date: Sat, 25 Jul 2015 16:05:52 +0200 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote: >> linux/ieee80211.h already defines constants for information element IDs. >> Include it where needed, resolve discrepancies in naming, and remove the >> duplicated definitions. >> >> While at it, wrap a line that was too long and remove extra parentheses >> in an expression that mixes only equality and logical operators. > > This patch doesn't apply at all. My mistake, sorry. I've generated it against v4.2-rc3. > Also, don't do more than one thing in a single patch, this should be > broken up into multiple ones. OK, I'll redo it with style fixes split out into a separate patch. Cheers, Jakub