From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932445AbbE2P4A (ORCPT ); Fri, 29 May 2015 11:56:00 -0400 Received: from mga03.intel.com ([134.134.136.65]:63024 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932349AbbE2Pzw convert rfc822-to-8bit (ORCPT ); Fri, 29 May 2015 11:55:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,517,1427785200"; d="scan'208";a="737431511" From: Andi Kleen To: Martin =?utf-8?Q?Li=C5=A1ka?= Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: [RFC] Add --show-total-period for perf annotate References: <555F3F8A.6000204@suse.cz> <87mw0wc4vt.fsf@tassilo.jf.intel.com> <5562D33F.70706@suse.cz> <20150525151450.GK19417@two.firstfloor.org> <5564685D.1020204@suse.cz> <20150526170316.GO19417@two.firstfloor.org> <55658462.1000605@suse.cz> <20150527140431.GT19417@two.firstfloor.org> <55686262.7010307@suse.cz> Date: Fri, 29 May 2015 08:55:49 -0700 In-Reply-To: <55686262.7010307@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Fri, 29 May 2015 14:58:10 +0200") Message-ID: <877frridiy.fsf@tassilo.jf.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Martin Liška writes: > > Following patch sums samples that belong to a line in assembly language. > What do you think about it, would it be acceptable solution? Basic patch looks good to me now. Thanks. The only ugly thing is the global variable, perhaps that could be cleaned up. -Andi -- ak@linux.intel.com -- Speaking for myself only