From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
<linux-wireless@vger.kernel.org>,
Brett Rudley <brudley@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
Christophe Prigent <christophe.prigent@intel.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] brcmfmac: Do not crash if platform data is not populated
Date: Tue, 23 Dec 2014 19:00:51 +0200 [thread overview]
Message-ID: <877fxie1x8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <54999161.504@broadcom.com> (Arend van Spriel's message of "Tue, 23 Dec 2014 16:59:29 +0100")
Arend van Spriel <arend@broadcom.com> writes:
> On 12/23/14 16:47, Mika Westerberg wrote:
>> On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote:
>>> On 12/23/14 15:48, Mika Westerberg wrote:
>>>> The driver looks for pdata->oob_irq_supported to find out if wowl can be
>>>> supported. However, not all platforms populate pdata in which case we crash
>>>> the kernel because of NULL pointer dereference.
>>>
>>> Thanks, Mika
>>>
>>> However, this was already reported by Dan Carpenter and I submitted a patch
>>> for that a couple of days ago: "[PATCH 02/10] brcmfmac: Fix possible
>>> dereference of NULL pointer." [1].
>>>
>>> Regards,
>>> Arend
>>>
>>> [1]
>>> http://mid.gmane.org/1419162233-19492-3-git-send-email-arend@broadcom.com
>>
>> Oh, good. I didn't notice that one.
>>
>> Thanks for fixing it :)
>>
>> BTW, that patch seems to miss brcmf_ops_sdio_resume(), perhaps it is
>> fixed in another patch?
>
> Aargh, a nice "BTW" this is as there is no other patch for the resume
> code. Maybe I should ask Kalle to apply your patch instead of ours. If
> it did not already got applied.
I have been waiting for net-next to open so I haven't applied any -next
patches yet. So if you want I can take Mika's patch as well. Just send a
reply to your patch I should drop.
And should this patch go to 3.19?
--
Kalle Valo
next prev parent reply other threads:[~2014-12-23 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 14:48 [PATCH] brcmfmac: Do not crash if platform data is not populated Mika Westerberg
2014-12-23 15:37 ` Arend van Spriel
2014-12-23 15:47 ` Mika Westerberg
2014-12-23 15:59 ` Arend van Spriel
2014-12-23 17:00 ` Kalle Valo [this message]
2014-12-23 17:33 ` Arend van Spriel
2014-12-24 13:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fxie1x8.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=christophe.prigent@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox