From: Rusty Russell <rusty@rustcorp.com.au>
To: Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
David Howells <dhowells@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
keescook@chromium.org
Subject: Re: [PATCH 1/2] test: add minimal module for verification testing
Date: Wed, 04 Dec 2013 10:22:48 +1030 [thread overview]
Message-ID: <877gblxzjj.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1386106054-27636-2-git-send-email-keescook@chromium.org>
Kees Cook <keescook@chromium.org> writes:
> When doing module loading verification tests (for example, with module
> singing, or LSM hooks), it is very handy to have a module that can be
> built on all systems under test, isn't auto-loaded at boot, and has
> no device or similar dependencies. This creates the "test_module.ko"
> module for that purpose, which only reports its load and unload to printk.
Bikeshed time!
> +#define pr_fmt(fmt) "test_module: " fmt
Perhaps:
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Cheers,
Rusty.
next prev parent reply other threads:[~2013-12-04 0:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 21:27 [PATCH 0/2] test modules Kees Cook
2013-12-03 21:27 ` [PATCH 1/2] test: add minimal module for verification testing Kees Cook
2013-12-03 21:36 ` Andrew Morton
2013-12-03 23:52 ` Rusty Russell [this message]
2013-12-03 21:27 ` [PATCH 2/2] test: check copy_to/from_user boundary validation Kees Cook
2013-12-03 21:47 ` Andrew Morton
2013-12-03 22:03 ` Kees Cook
2013-12-03 21:53 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gblxzjj.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox