From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755644Ab3LDAyT (ORCPT ); Tue, 3 Dec 2013 19:54:19 -0500 Received: from ozlabs.org ([203.10.76.45]:55810 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754450Ab3LDAyS (ORCPT ); Tue, 3 Dec 2013 19:54:18 -0500 From: Rusty Russell To: Kees Cook , linux-kernel@vger.kernel.org Cc: Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Peter Zijlstra , David Howells , Dave Hansen , "Paul E. McKenney" , keescook@chromium.org Subject: Re: [PATCH 1/2] test: add minimal module for verification testing In-Reply-To: <1386106054-27636-2-git-send-email-keescook@chromium.org> References: <1386106054-27636-1-git-send-email-keescook@chromium.org> <1386106054-27636-2-git-send-email-keescook@chromium.org> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Wed, 04 Dec 2013 10:22:48 +1030 Message-ID: <877gblxzjj.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > When doing module loading verification tests (for example, with module > singing, or LSM hooks), it is very handy to have a module that can be > built on all systems under test, isn't auto-loaded at boot, and has > no device or similar dependencies. This creates the "test_module.ko" > module for that purpose, which only reports its load and unload to printk. Bikeshed time! > +#define pr_fmt(fmt) "test_module: " fmt Perhaps: #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Cheers, Rusty.