From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758303Ab3JKLE4 (ORCPT ); Fri, 11 Oct 2013 07:04:56 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:58976 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758149Ab3JKLEx (ORCPT ); Fri, 11 Oct 2013 07:04:53 -0400 From: Luis Henriques To: David Vrabel Cc: , , , Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH 092/100] xen/hvc: allow xenboot console to be used again References: <1381488130-30235-1-git-send-email-luis.henriques@canonical.com> <1381488130-30235-93-git-send-email-luis.henriques@canonical.com> <5257D893.3040105@citrix.com> Date: Fri, 11 Oct 2013 12:04:49 +0100 In-Reply-To: <5257D893.3040105@citrix.com> (David Vrabel's message of "Fri, 11 Oct 2013 11:53:07 +0100") Message-ID: <877gdkcbla.fsf@canonical.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Vrabel writes: > On 11/10/13 11:42, Luis Henriques wrote: >> 3.5.7.23 -stable review patch. If anyone has any objections, please let me know. > > It's harmless to backport this, but it is only needed in 3.10 and later > (unless you've backported d0380e6c). Ups, you're right. I'll drop this from the 3.5 queue. Thanks! Cheers, -- Luis > >> From: David Vrabel >> >> commit a9fbf4d591da6cd1d3eaab826c7c15f77fc8f6a3 upstream. >> >> Commit d0380e6c3c0f6edb986d8798a23acfaf33d5df23 (early_printk: >> consolidate random copies of identical code) added in 3.10 introduced >> a check for con->index == -1 in early_console_register(). >> >> Initialize index to -1 for the xenboot console so earlyprintk=xen >> works again. >> >> Signed-off-by: David Vrabel >> Cc: Greg Kroah-Hartman >> Cc: Jiri Slaby >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Luis Henriques >> --- >> drivers/tty/hvc/hvc_xen.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c >> index 944eaeb..78873df 100644 >> --- a/drivers/tty/hvc/hvc_xen.c >> +++ b/drivers/tty/hvc/hvc_xen.c >> @@ -634,6 +634,7 @@ struct console xenboot_console = { >> .name = "xenboot", >> .write = xenboot_write_console, >> .flags = CON_PRINTBUFFER | CON_BOOT | CON_ANYTIME, >> + .index = -1, >> }; >> #endif /* CONFIG_EARLY_PRINTK */ >> > > David