From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Chao Xie <chao.xie@marvell.com>
Cc: <haojian.zhuang@gmail.com>, <xiechao.mail@gmail.com>,
<linux@arm.linux.org.uk>, <a.zummo@towertech.it>,
<rtc-linux@googlegroups.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<akpm@linux-foundation.org>, <liangs@marvell.com>
Subject: Re: [PATCH 1/2] Revert "drivers/rtc/rtc-pxa.c: fix set time sync time issue"
Date: Thu, 09 May 2013 18:35:12 +0200 [thread overview]
Message-ID: <877gj8i01r.fsf@free.fr> (raw)
In-Reply-To: <1367889447-15619-2-git-send-email-chao.xie@marvell.com> (Chao Xie's message of "Mon, 6 May 2013 21:17:26 -0400")
Chao Xie <chao.xie@marvell.com> writes:
> This patch have something wrong.
> 1.The pxa_sync_time API is not needed. The RTC sync can be done
> by user space applications, so in kernel this API is not needed.
> 2.The pxa_rtc_open can not be deleted. This change has been
> declined during review at the mail list
> 3.Based on specification and talked with owner of driver, it
> does not matter to set WOM and DOW.
>
> Only need to keep PSBR control for pxa95x
>
> This reverts commit 57489fabb7f3fc02483df2125fdbfb8b1bb1fcd8.
This commit doesn't exist in Linus's tree. Maybe in linux-next ?
Anyway, as you are reverting, please consider this :
the commit that exists is : c4243de70f7d536d95196b8a31539298bb15238c
"drivers/rtc/rtc-pxa.c: drivers/rtc/rtc-pxa.c: fix alarm not match issue".
This commit should be reverted :
- because it's wrong :
> tm->tm_wday = ((rycr & RDxR_DOW_MASK) >> RDxR_DOW_S) - 1;
See how RYCR is used with a RDCR mask ...
- because as maintainer I have already nacked this kind of patch :
https://patchwork.kernel.org/patch/1819851/
The reasons given here are still valid AFAIK.
I'm pretty sure I didn't receive this patch in my mailbox. After I refused
ChaoXie first patch, the second "same approach" patch from Liangs was sent in my
back. I don't understand how that could happen ...
Liangs, please make sure to add me to the reviewers next time ?
Cheers.
--
Robert
next prev parent reply other threads:[~2013-05-09 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 1:17 [PATCH 0/2] rtc: pxa: add pxa95x rtc support Chao Xie
2013-05-07 1:17 ` [PATCH 1/2] Revert "drivers/rtc/rtc-pxa.c: fix set time sync time issue" Chao Xie
2013-05-09 16:35 ` Robert Jarzmik [this message]
2013-05-07 1:17 ` [PATCH 2/2] rtc: pxa: add pxa95x rtc support Chao Xie
2013-05-07 1:48 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gj8i01r.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=chao.xie@marvell.com \
--cc=haojian.zhuang@gmail.com \
--cc=liangs@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rtc-linux@googlegroups.com \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox