From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Devendra Naga <devendra.aaru@gmail.com>,
Lior Dotan <liodot@gmail.com>,
Christopher Harrer <charrer@alacritech.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/3] staging/slicoss: disable pci device at remove
Date: Mon, 09 Jul 2012 13:09:23 -0700 [thread overview]
Message-ID: <877guc4ryk.fsf@xmission.com> (raw)
In-Reply-To: <20120709200604.GA2536@kroah.com> (Greg Kroah-Hartman's message of "Mon, 9 Jul 2012 13:06:04 -0700")
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Mon, Jul 09, 2012 at 11:04:19PM +0530, Devendra Naga wrote:
>> at probe we enabled the device, and we should disable it at remove.
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>> ---
>> drivers/staging/slicoss/slicoss.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
>> index a511a2b..5bd3825 100644
>> --- a/drivers/staging/slicoss/slicoss.c
>> +++ b/drivers/staging/slicoss/slicoss.c
>> @@ -3234,6 +3234,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
>> }
>> free_netdev(dev);
>> pci_release_regions(pcidev);
>> + pci_disable_device(pcidev);
>
> No, you really shouldn't do this, see the many times this has come up on
> the linux-kernel mailing list for why.
I haven't see this? Why don't you want to disable a device at remove
time? Because we put the disable in the generic pci layer?
Eric
next prev parent reply other threads:[~2012-07-09 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 17:34 [PATCH 1/3] staging/slicoss: remove not-needed ASSERT Devendra Naga
2012-07-09 17:34 ` [PATCH 2/3] staging/slicoss: disable pci device at remove Devendra Naga
2012-07-09 20:06 ` Greg Kroah-Hartman
2012-07-09 20:09 ` Eric W. Biederman [this message]
2012-07-10 18:28 ` Greg Kroah-Hartman
2012-07-11 5:03 ` devendra.aaru
2012-07-09 17:34 ` [PATCH 3/3] staging/slicoss: return -ENODEV if no devid matches Devendra Naga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877guc4ryk.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox