From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH RFT 2/2] regulator: max1586: Convert max1586_v3_ops to set_voltage_sel and map_voltage_linear
Date: Sun, 10 Jun 2012 20:11:38 +0200 [thread overview]
Message-ID: <877gvfvxyd.fsf@free.fr> (raw)
In-Reply-To: <1339115204.4310.4.camel@phoenix> (Axel Lin's message of "Fri, 08 Jun 2012 08:26:44 +0800")
Axel Lin <axel.lin@gmail.com> writes:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Hi Axel,
The patches look OK to me, but I cannot build them.
Even on top of linux-next, I get :
drivers/regulator/max1586.c: In function 'max1586_v6_set_voltage_sel':
drivers/regulator/max1586.c:86:2: error: 'const struct regulator_desc' has no member named 'volt_table'
drivers/regulator/max1586.c: At top level:
drivers/regulator/max1586.c:105:18: error: 'regulator_list_voltage_table' undeclared here (not in a function)
drivers/regulator/max1586.c:123:3: error: unknown field 'volt_table' specified in initializer
drivers/regulator/max1586.c:123:3: warning: initialization from incompatible pointer type [enabled by default]
drivers/regulator/max1586.c:123:3: warning: (near initialization for 'max1586_reg[1].ops') [enabled by default]
I suppose you're basing your tree on top of a set of commits not available in
linux-next (maybe Mark's regulator tree ?). As I don't have that tree in mind,
it would be kind to tell me which tree you're basing your work on, so that I
could test your last patches.
Cheers.
--
Robert
next prev parent reply other threads:[~2012-06-10 18:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 0:25 [PATCH RFT 1/2] regulator: max1586: Convert max1586_v3_ops to regulator_list_voltage_linear Axel Lin
2012-06-08 0:26 ` [PATCH RFT 2/2] regulator: max1586: Convert max1586_v3_ops to set_voltage_sel and map_voltage_linear Axel Lin
2012-06-10 18:11 ` Robert Jarzmik [this message]
2012-06-10 23:27 ` Axel Lin
2012-06-11 18:09 ` Robert Jarzmik
2012-06-11 18:42 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gvfvxyd.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox