public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Douglas <william.r.douglas@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] printk: Fix bounds checking for log_prefix.
Date: Mon, 15 Aug 2011 14:15:04 -0700	[thread overview]
Message-ID: <877h6e2x7r.fsf@intel.com> (raw)

Currently log_prefix is testing that the first character of the
log level and facility is less than '0' and greater than '9' (which
is always false).  It should be testing to see if the character
less than '0' or greater than '9' instead.  This patch makes that
change.

The code being changed worked because strtoul bombs out (endp isn't
updated) and 0 is returned anyway.
Signed-off-by: William Douglas <william.douglas@intel.com>
---
 kernel/printk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/printk.c b/kernel/printk.c
index 37dff34..42080686 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -590,7 +590,7 @@ static size_t log_prefix(const char *p, unsigned int *level, char *special)
 		/* multi digit including the level and facility number */
 		char *endp = NULL;
 
-		if (p[1] < '0' && p[1] > '9')
+		if (p[1] < '0' || p[1] > '9')
 			return 0;
 
 		lev = (simple_strtoul(&p[1], &endp, 10) & 7);
-- 
1.7.6

             reply	other threads:[~2011-08-15 21:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15 21:15 William Douglas [this message]
2011-08-15 21:54 ` [PATCHv2] printk: Remove bounds checking for log_prefix William Douglas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877h6e2x7r.fsf@intel.com \
    --to=william.r.douglas@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox