From: Andi Kleen <andi@firstfloor.org>
To: Kees Cook <kees.cook@canonical.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] security: Yama LSM
Date: Wed, 23 Jun 2010 13:43:41 +0200 [thread overview]
Message-ID: <877hlqas9e.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100623065236.GH5876@outflux.net> (Kees Cook's message of "Tue, 22 Jun 2010 23:52:36 -0700")
Kees Cook <kees.cook@canonical.com> writes:
> +
> +config SECURITY_YAMA_SYMLINKS
> + bool "Yama: protect symlink following in sticky world-writable
> dirs"
IMHO it's bad style to have CONFIGs that just set defaults,
if that can be done at runtime too. Especially as in your case if it's
a lot of settings. Is it that bad to have a init script and drop these
CONFIGs?
However the help texts are useful, these should be in the sysctl
documentatin in Documentation instead.
> + if (rc) {
> + printk_ratelimited(KERN_INFO "ptrace of non-child"
> + " pid %d was attempted by: %s (pid %d)\n",
> + child->pid, get_task_comm(name, current),
> + current->pid);
It's probably obscure and other kernel code has this too, but at some point
there were attacks to use terminal ESC sequences to attack root's
terminal when they dmesg. Couldn't that be done through "comm" here?
At least the other code who has this problem doesn't claim to enhance
security :)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-06-23 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 6:52 [PATCH v2] security: Yama LSM Kees Cook
2010-06-23 11:43 ` Andi Kleen [this message]
2010-06-23 14:54 ` Kees Cook
2010-06-23 15:34 ` Andi Kleen
2010-06-23 15:59 ` Alan Cox
2010-06-23 19:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hlqas9e.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=kees.cook@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox