From: Dmitry Monakhov <dmonakhov@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: jens.axboe@oracle.com, Vivek Goyal <vgoyal@redhat.com>
Subject: CFQ is broken for CONFIG_BLK_CGROUP=y, CFQ_GROUP_IOSCHED=n
Date: Wed, 28 Apr 2010 16:44:51 +0400 [thread overview]
Message-ID: <877hnrg30c.fsf@openvz.org> (raw)
I've had an oops on kernel boot due to NULL pointer deference
linux-2.6-block/for-next HEAD:7eaed1226ab411ee5dc8c34fc0d8034e4c98e3c6
I've enabled CONFIG_BLK_CGROUP, but not CFQ_GROUP_IOSCHED
In this case cfq_ref_get_cfqg() defined as
static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg)
{
return NULL;
}
So following call trace is simply NOOP
cfq_set_request()
rq->elevator_private3 = cfq_ref_get_cfqg(cfqq->cfqg);
Which later result in OOPS on bio insertion
cfq_insert_request
-> blkiocg_update_io_add_stats(&(RQ_CFQG(rq))->blkg,...)
-> spin_lock_irqsave(&blkg->stats_lock, flags);
Bad commit.
>From 7f1dc8a2d2f45fc557b27fd56115338b1d34fc24 Mon Sep 17 00:00:00 2001
From: Vivek Goyal <vgoyal@redhat.com>
Date: Wed, 21 Apr 2010 17:44:16 +0200
Subject: [PATCH] blkio: Fix blkio crash during rq stat update
next reply other threads:[~2010-04-28 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 12:44 Dmitry Monakhov [this message]
2010-04-28 13:48 ` CFQ is broken for CONFIG_BLK_CGROUP=y, CFQ_GROUP_IOSCHED=n Vivek Goyal
2010-04-28 15:09 ` Vivek Goyal
2010-04-28 15:36 ` Dmitry Monakhov
2010-04-28 15:44 ` Vivek Goyal
2010-04-28 17:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hnrg30c.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox