From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: users of mod_timer_msec()
Date: Sat, 02 Jan 2010 20:11:45 +0100 [thread overview]
Message-ID: <877hs0724u.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100102105012.40d678f2@infradead.org> (Arjan van de Ven's message of "Sat, 2 Jan 2010 10:50:12 -0800")
Arjan van de Ven <arjan@infradead.org> writes:
> emp->activity++;
> if (!timer_pending(&emp->timer))
> - mod_timer(&emp->timer, jiffies + msecs_to_jiffies(10));
> + mod_timer_msec(&emp->timer, 10);
... but your original patch does
+int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
+{
+ return mod_timer(timer, msecs_to_jiffies(delay_ms));
That doesn't look equivalent.
mod_timer_msec should mod_timer_msec_plus_jiffies?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-02 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 18:48 [PATCH] timer: Introduce mod_timer_msec() Arjan van de Ven
2010-01-02 18:50 ` users of mod_timer_msec() Arjan van de Ven
2010-01-02 19:11 ` Andi Kleen [this message]
2010-01-02 19:19 ` Arjan van de Ven
2010-01-02 19:21 ` [PATCH v2] timer: Introduce mod_timer_msec() Arjan van de Ven
2010-01-02 19:30 ` Dmitry Torokhov
2010-01-02 19:36 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hs0724u.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox