Re: [PATCH] DaVinci: MMC: MMC/SD controller driver for DaVinci family

[Kevin Hilman <khilman@deeprootsystems.com>]

Vipin Bhandari <vipin.bhandari@ti.com> writes:

> This patch adds support for MMC/SD controller driver for all DaVinci family
> SoC. This patch supports davinci family SoC's DM6446, DM355, DM365 and
> DA830/OMAPL137.
>
> The patch has been tested on DM355 EVM.
>
> The MMCSD controller specifications for DM355 can be found at
> http://focus.ti.com/general/docs/litabsmultiplefilelist.tsp?literatureNumber=spruee2c
>
> Signed-off-by: Vipin Bhandari <vipin.bhandari@ti.com>
> Signed-off-by: Purshotam Kumar <purushotam@ti.com>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>

Vipin,

In addition to this, I've also been carrying the diff below in DaVinci
git.  Is this change still necessary?

Kevin


diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index fe8f613..6c76f64 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -178,7 +178,7 @@ struct mmc_davinci_host {
 	u32 buffer_bytes_left;
 	u32 bytes_left;
 
-	u8 rxdma, txdma;
+	u32 rxdma, txdma;
 	bool use_dma;
 	bool do_dma;
 
@@ -190,7 +190,7 @@ struct mmc_davinci_host {
 	struct edmacc_param	tx_template;
 	struct edmacc_param	rx_template;
 	unsigned		n_link;
-	u8			links[NR_SG - 1];
+	u32			links[NR_SG - 1];
 
 	/* For PIO we walk scatterlists one segment at a time. */
 	unsigned int		sg_len;