From: Ed L Cashin <ecashin@coraid.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 2.6.12-rc2] aoe [5/6]: add firmware version to info in sysfs
Date: Wed, 20 Apr 2005 15:13:03 -0400 [thread overview]
Message-ID: <877jixmfcw.fsf@coraid.com> (raw)
In-Reply-To: <20050420103723.52598eb8.rddunlap@osdl.org> (Randy Dunlap's message of "Wed, 20 Apr 2005 10:37:23 -0700")
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
"Randy.Dunlap" <rddunlap@osdl.org> writes:
...
> so something like 'firmware-version' would be appreciated
> (for the sysfs filename).
Fair enough. This patch follows and depends on the fifth patch of the
six.
use a more explicit filename for sysfs firmware version info
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
[-- Attachment #2: patch-135 --]
[-- Type: text/plain, Size: 828 bytes --]
diff -urNp a-exp/linux/drivers/block/aoe/aoeblk.c b-exp/linux/drivers/block/aoe/aoeblk.c
--- a-exp/linux/drivers/block/aoe/aoeblk.c 2005-04-20 15:09:13.000000000 -0400
+++ b-exp/linux/drivers/block/aoe/aoeblk.c 2005-04-20 15:09:13.000000000 -0400
@@ -58,7 +58,7 @@ static struct disk_attribute disk_attr_n
.show = aoedisk_show_netif
};
static struct disk_attribute disk_attr_fwver = {
- .attr = {.name = "fwver", .mode = S_IRUGO },
+ .attr = {.name = "firmware-version", .mode = S_IRUGO },
.show = aoedisk_show_fwver
};
@@ -76,7 +76,7 @@ aoedisk_rm_sysfs(struct aoedev *d)
sysfs_remove_link(&d->gd->kobj, "state");
sysfs_remove_link(&d->gd->kobj, "mac");
sysfs_remove_link(&d->gd->kobj, "netif");
- sysfs_remove_link(&d->gd->kobj, "fwver");
+ sysfs_remove_link(&d->gd->kobj, "firmware-version");
}
static int
[-- Attachment #3: Type: text/plain, Size: 42 bytes --]
--
Ed L Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2005-04-20 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-20 17:02 [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration Ed L Cashin
2005-04-20 17:05 ` [PATCH 2.6.12-rc2] aoe [2/6]: aoe-stat should work for built-in as well as module Ed L Cashin
2005-04-20 17:05 ` [PATCH 2.6.12-rc2] aoe [3/6]: update the documentation to mention aoetools Ed L Cashin
2005-04-20 17:06 ` [PATCH 2.6.12-rc2] aoe [4/6]: allow multiple aoe devices to have the same mac Ed L Cashin
2005-04-20 17:06 ` [PATCH 2.6.12-rc2] aoe [5/6]: add firmware version to info in sysfs Ed L Cashin
2005-04-20 17:37 ` Randy.Dunlap
2005-04-20 19:13 ` Ed L Cashin [this message]
2005-04-20 17:06 ` [PATCH 2.6.12-rc2] aoe [6/6]: update version number to 10 Ed L Cashin
2005-04-20 17:16 ` [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration Randy.Dunlap
2005-04-20 17:27 ` Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877jixmfcw.fsf@coraid.com \
--to=ecashin@coraid.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox