From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Paul Mackerras <paulus@samba.org>, Dave Jones <davej@redhat.com>,
benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: AGP bogosities
Date: Sun, 13 Mar 2005 07:26:32 +0900 [thread overview]
Message-ID: <877jkcmrfr.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <Pine.LNX.4.58.0503120906020.2398@ppc970.osdl.org> (Linus Torvalds's message of "Sat, 12 Mar 2005 09:09:00 -0800 (PST)")
Linus Torvalds <torvalds@osdl.org> writes:
> Btw, this should probably check for negative 32-bit values too, ie the
> test should probably be
>
> if ((int)atomic_read(v) <= 0)
>
> and it should probably be done for the regular atomic_dec() etc cases too,
> not just the dec-and-test. "atomic" values simply aren't historically
> well-defined for negative values (sparc used to limit them to 24 bits), so
> a negative thing would always be a bug, I think.
However, inode->i_writecount and some stuffs seems to be already using
the negative values (or sparc was used the signed 24 bits value).
Anyway, unfortunately inode->i_writecount triggered in atomic_dec().
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2005-03-12 22:29 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 1:24 AGP bogosities Paul Mackerras
2005-03-11 2:04 ` Jesse Barnes
2005-03-11 2:11 ` Paul Mackerras
2005-03-11 2:18 ` Jesse Barnes
2005-03-11 2:38 ` Benjamin Herrenschmidt
2005-03-11 4:02 ` Jesse Barnes
2005-03-11 4:30 ` Benjamin Herrenschmidt
2005-03-11 16:39 ` Jesse Barnes
2005-03-11 17:59 ` Bjorn Helgaas
2005-03-11 18:04 ` Jesse Barnes
2005-03-12 3:27 ` Mike Werner
2005-03-12 3:58 ` Dave Jones
2005-03-13 3:13 ` Jesse Barnes
2005-03-13 4:08 ` Dave Jones
2005-03-13 4:28 ` Dave Jones
2005-03-11 22:43 ` Paul Mackerras
2005-03-11 23:22 ` Bjorn Helgaas
2005-03-12 0:12 ` Benjamin Herrenschmidt
2005-03-12 1:34 ` Paul Mackerras
2005-03-11 18:04 ` James Simmons
2005-03-11 18:08 ` Jesse Barnes
2005-03-11 2:04 ` Linus Torvalds
2005-03-11 2:12 ` Dave Jones
2005-03-11 2:18 ` Paul Mackerras
2005-03-11 2:23 ` Dave Jones
2005-03-11 2:40 ` Benjamin Herrenschmidt
2005-03-11 2:49 ` Dave Jones
2005-03-12 20:49 ` Greg KH
2005-03-11 2:42 ` Linus Torvalds
2005-03-11 22:18 ` OGAWA Hirofumi
2005-03-11 22:26 ` Dave Jones
2005-03-11 22:33 ` Chris Wedgwood
2005-03-11 23:52 ` Gene Heskett
2005-03-11 22:44 ` Linus Torvalds
2005-03-11 23:09 ` Paul Mackerras
2005-03-12 0:06 ` Gene Heskett
2005-03-14 8:17 ` Pavel Machek
2005-03-14 8:27 ` David Lang
2005-03-14 8:37 ` dmesg verbosity [was Re: AGP bogosities] Pavel Machek
2005-03-14 16:55 ` Jesse Barnes
2005-03-14 17:03 ` Pavel Machek
2005-03-14 17:17 ` Dave Jones
2005-03-14 17:18 ` Linus Torvalds
2005-03-14 17:27 ` Jesse Barnes
2005-03-14 17:27 ` Pavel Machek
2005-03-15 20:18 ` Greg Stark
2005-03-14 18:12 ` Diego Calleja
2005-03-14 19:07 ` Lee Revell
2005-03-20 6:44 ` David Lang
2005-03-23 0:37 ` Diego Calleja
2005-03-23 0:53 ` Lee Revell
2005-03-23 1:13 ` Dave Jones
2005-03-23 1:29 ` Andrew Morton
2005-03-23 8:21 ` Giuseppe Bilotta
2005-03-23 16:14 ` Dave Jones
2005-03-23 16:49 ` Giuseppe Bilotta
2005-03-23 17:17 ` Dave Jones
2005-03-23 14:10 ` Diego Calleja
2005-03-23 8:19 ` Giuseppe Bilotta
2005-03-30 9:45 ` Pavel Machek
2005-03-23 0:53 ` Zan Lynx
2005-03-23 0:55 ` Grant Coady
2005-03-14 21:55 ` Benjamin Herrenschmidt
2005-03-14 22:08 ` David Lang
2005-03-15 0:02 ` Pavel Machek
2005-03-11 22:42 ` AGP bogosities Dmitry Torokhov
2005-03-11 22:47 ` Dmitry Torokhov
2005-03-12 17:09 ` Linus Torvalds
2005-03-12 22:26 ` OGAWA Hirofumi [this message]
2005-03-12 22:34 ` Linus Torvalds
2005-03-11 2:35 ` Benjamin Herrenschmidt
2005-03-11 2:43 ` Dave Jones
2005-03-11 2:37 ` Linus Torvalds
2005-03-11 22:11 ` J.A. Magallon
2005-03-11 22:18 ` Dave Jones
2005-03-11 22:46 ` J.A. Magallon
2005-03-11 23:16 ` Martin Schlemmer
2005-03-11 23:17 ` J.A. Magallon
2005-03-11 23:23 ` Martin Schlemmer
2005-03-11 23:24 ` J.A. Magallon
-- strict thread matches above, loose matches on Subject: below --
2005-03-12 4:33 Ken Ryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877jkcmrfr.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=benh@kernel.crashing.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox