From: Ross Biro <ross.biro@gmail.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_*
Date: Fri, 5 Nov 2004 22:45:04 -0500 [thread overview]
Message-ID: <8783be660411051945252097c3@mail.gmail.com> (raw)
In-Reply-To: <20041106032314.GC6060@taniwha.stupidest.org>
On Fri, 5 Nov 2004 19:23:14 -0800, Chris Wedgwood <cw@f00f.org> wrote:
> @@ -434,7 +434,7 @@
> try_to_flush_leftover_data(drive);
> if (hwif->INB(IDE_STATUS_REG) & (BUSY_STAT|DRQ_STAT)) {
> /* force an abort */
> - hwif->OUTB(WIN_IDLEIMMEDIATE,IDE_COMMAND_REG);
> + hwif->OUTB(ATA_CMD_IDLEIMMEDIATE,IDE_COMMAND_REG);
> }
> if (rq->errors >= ERROR_MAX || blk_noretry_request(rq))
> DRIVER(drive)->end_request(drive, 0, 0);
Just a reminder, this error recovery doesn't work on many modern hard
drives, and is a violation of all ATA specs after ATA-2*. In
particular, most Maxtor and Western Digital Drives will not recover
from errors with this command sequence. The preferred error recovery
is to do a reset followed by a set features, because that is what
Windows does (as told to me by a drive vendor). I've tested the
reset/set features method of error recovery and it works on all the
drives I've tried. I have not tried it on any older drives, or any
other types of ATAPI devices.
Ross
*Most drives set the ATA-2 support flag, so technically they are in
violation of the ATA spec if they don't support this error recovery,
but the drive vendors don't care, they just make sure it works with
windows.
next prev parent reply other threads:[~2004-11-06 3:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 9:11 [PATCH] IDE remove some cruft from ide.h Chris Wedgwood
2004-11-05 2:43 ` Jeff Garzik
2004-11-05 13:16 ` Bartlomiej Zolnierkiewicz
2004-11-06 3:22 ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion: comments Chris Wedgwood
2004-11-06 3:23 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion: add new entries to ata.h Chris Wedgwood
2004-11-06 16:48 ` Jeff Garzik
2004-11-06 17:05 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion (take #2): comments Chris Wedgwood
2004-11-07 6:04 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion (take #2): add new entries to ata.h Chris Wedgwood
2004-11-08 2:30 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion (take #2): convert users of WIN_* to ATA_CMD_* Chris Wedgwood
2004-11-07 6:04 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion (take #2): cleanup hdreg.h Chris Wedgwood
2004-11-06 3:23 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_* Chris Wedgwood
2004-11-06 3:45 ` Ross Biro [this message]
2004-11-06 3:55 ` Chris Wedgwood
2004-11-06 14:53 ` Ross Biro
2004-11-08 8:55 ` Jens Axboe
2004-11-06 3:23 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion: cleanup hdreg.h Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8783be660411051945252097c3@mail.gmail.com \
--to=ross.biro@gmail.com \
--cc=bzolnier@gmail.com \
--cc=cw@f00f.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox