From: Ross Biro <ross.biro@gmail.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
LKML <linux-kernel@vger.kernel.org>,
Andre Hedrick <andre@pyxtechnologies.com>
Subject: Re: [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_*
Date: Sat, 6 Nov 2004 09:53:56 -0500 [thread overview]
Message-ID: <8783be660411060653735238de@mail.gmail.com> (raw)
In-Reply-To: <20041106035522.GA13091@taniwha.stupidest.org>
On Fri, 5 Nov 2004 19:55:22 -0800, Chris Wedgwood <cw@f00f.org> wrote:
> I assume for Windows they do that for all drives? Even older ones?
Most likely, but that doesn't imply that Windows XP works with ancient
ata drives.
>
> I also wonder what happens with TCQ when you get an error? Do you
> just retry everything outstanding?
My guess is yes, but I'll also bet the drive vendors have not tested
this path well.
> It probably should get fixed, there just doesn't seem to be much
> incentive to beat on the old IDE code though :( Minor cleanups seem
> worthwhile but anything intrusive I worry will break some hard-to-test
> platform for someone.
The best solution is probably to make it user selectable for now. I
know we need the reset/set features, or any sort of error causes a
major melt down. We can default to the current behaviour, so it
shouldn't break anything.
I'll make sure some patches for this are created sometime in the next
couple of months. I'll even try to make sure TCQ gets tested with
them if TCQ works well enough with the current code.
Ross
Ross
next prev parent reply other threads:[~2004-11-06 14:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 9:11 [PATCH] IDE remove some cruft from ide.h Chris Wedgwood
2004-11-05 2:43 ` Jeff Garzik
2004-11-05 13:16 ` Bartlomiej Zolnierkiewicz
2004-11-06 3:22 ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion: comments Chris Wedgwood
2004-11-06 3:23 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion: add new entries to ata.h Chris Wedgwood
2004-11-06 16:48 ` Jeff Garzik
2004-11-06 17:05 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion (take #2): comments Chris Wedgwood
2004-11-07 6:04 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion (take #2): add new entries to ata.h Chris Wedgwood
2004-11-08 2:30 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion (take #2): convert users of WIN_* to ATA_CMD_* Chris Wedgwood
2004-11-07 6:04 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion (take #2): cleanup hdreg.h Chris Wedgwood
2004-11-06 3:23 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_* Chris Wedgwood
2004-11-06 3:45 ` Ross Biro
2004-11-06 3:55 ` Chris Wedgwood
2004-11-06 14:53 ` Ross Biro [this message]
2004-11-08 8:55 ` Jens Axboe
2004-11-06 3:23 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion: cleanup hdreg.h Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8783be660411060653735238de@mail.gmail.com \
--to=ross.biro@gmail.com \
--cc=andre@pyxtechnologies.com \
--cc=bzolnier@gmail.com \
--cc=cw@f00f.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox