Re: [PATCH v5 5/5] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B

Krzysztof Kozlowski
2025-04-14T15:11:00Z

On 14/04/2025 16:57, Nam Tran wrote:
> Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
> This enables the LED connected to the LP5812 to be controlled via I2C.
>
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
> .../arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> index 353bb50ce542..0dec6ce44c6c 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> @@ -152,6 +152,66 @@ &hdmi1 {
> status = "okay";
> };
>
> +&i2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@1b {
> + compatible = "ti,lp5812";
> + reg = <0x1b>;

Messed indentation... You already got such comment about your DTS in the
binding. :/

Best regards,
Krzysztof