Re: [PATCH v5 1/5] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver

Krzysztof Kozlowski
2025-04-14T15:10:21Z

On 14/04/2025 16:57, Nam Tran wrote:
> +
> +description: |
> + The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
> + For more product information please see the link below:
> + https://www.ti.com/product/LP5812#tech-docs
> +
> +properties:
> + compatible:
> + const: ti,lp5812
> +
> + reg:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0

No need for supply?

> +
> +patternProperties:
> + "^led@[0-9a-b]$":
> + type: object
> + $ref: common.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + minimum: 0
> + maximum: 0xb
> +
> + chan-name:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: LED channel name

My comment stay valid. I don't think LEDs have channels, datasheet also
has nothing about channels, so again - use existing properties. Or
better drop it - I don't see any point in the name. The reg already
defines it.

However after dropping this, your example has nodes with only reg -
what's the point of them? Why no properties from common.yaml are
applicable? If they are not applicable, then the entire subnode should
be dropped - you don't need them to describe the hardware.

Best regards,
Krzysztof