The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: songxiebing <songxiebing@kylinos.cn>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/conexant: Set mic pin VREF to 0x24 on headset mic plug
Date: Tue, 25 Aug 2026 11:28:49 +0200	[thread overview]
Message-ID: <878q5utupa.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260825091303.1619519-1-songxiebing@kylinos.cn>

On Tue, 25 Aug 2026 11:13:03 +0200,
songxiebing wrote:
> 
> Hi Takashi,
> 
> 0x19 is configured as a mic pin, in cx_update_headset_mic_vref, it
> executes cx_process_headset_plugin only after confirming that a mic
> present is detected. A 4-pole headset is detected as either CTIA or
> OMTP and sets 0x24, but the 3-pole mic case is not handled, so a
> setting of 0x24 is added here.

OK, then you'd need to explain more in the patch description.
It implies that the patch corrects the debug output, too.

And, this also opens another door: why do we read those registers at
all?  Now you always set the pin control 0x24 no matter what the
connection type is.  So the whole headset type detection becomes
practically moot; it's used only for showing a debug print.


thanks,

Takashi

  reply	other threads:[~2026-08-25  9:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  2:38 [PATCH] ALSA: hda/conexant: Set mic pin VREF to 0x24 on headset mic plug songxiebing
2026-08-25  8:22 ` Takashi Iwai
2026-08-25  9:13 ` songxiebing
2026-08-25  9:28   ` Takashi Iwai [this message]
2026-08-25  9:45 ` songxiebing
2026-08-25  9:55   ` Takashi Iwai
2026-08-26  1:12 ` songxiebing
2026-08-26  1:45 ` [PATCH v2] ALSA: hda/conexant: Refactor headset plug detection songxiebing
2026-08-26  8:48   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q5utupa.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=songxiebing@kylinos.cn \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox