From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5E063ACF05
	for <linux-kernel@vger.kernel.org>; Sat, 27 Jun 2026 11:00:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782558003; cv=none; b=pch8w8MHpb+uNJO/MsjVdtkkGl4q4BxVcAsxj6rIdXT4biSiatZrfkThIvwaNm0N7D8GnoIugWPgAiwexyQN2R1O9KXk26mDDkLh6+5kuc3Ww7+S51FyFfX6N0QtYRpRT1EtjQBugFvCwVrtxMEIdoT9IJHDxUpsSqa7vFxLE6I=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782558003; c=relaxed/simple;
	bh=0Z0jNnrEg32cWn9Xjj3qRD3bx+C2JhgHhs1l2ofbWE8=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=Xkf1KMmIhhhUTmbDjqjIZclLf7a3bEhsWFF+HGnZpWbCPk8PDEIbHBCgF0LkvdmlJRmJQEo0LwMpB56rO6wqwsJLfwti4W6vD1Ajs2a6Y/sye+/2aaFQnzAKnKhf20M3NhXEhXvJo9YgGOv8Nlzc0CU4ku9deQxjlI1yJqEugX8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=AncN2O0D; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=yJx47qRo; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="AncN2O0D";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="yJx47qRo"
From: Nam Cao <namcao@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1782557994;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0Z0jNnrEg32cWn9Xjj3qRD3bx+C2JhgHhs1l2ofbWE8=;
	b=AncN2O0Dkh0QT7cFAI5Y49CbxgjI0J+qAtUmddy5gad33c+lThT4GOYxb8VyTDbb1XX/AJ
	PqIDNp9oFrCHh7BexVAuFa9WqaoUtVenE5fEKqLxZtZ5OwNAh6Ju89kD8WxX3yLuBdZiL7
	YZzYAnQolLRt1ic3/JLeeuwvsCfNxubDPbaiOgTktntzY5qqlcDK2xi3PXEbj4rryRzp/i
	pWMMrTPgwNP4eA/y9RFHkEhtp95LUD+PPmdA4urQlkGyA8jcbtKX5QJ8OZeaSS1LxLGwJb
	OFBGW+i1K3Q1+2DhGxoIKvJ5U6Ha/Ive8YAkUzPfKKtgdXPSnsQfAs54FMRoOg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1782557994;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0Z0jNnrEg32cWn9Xjj3qRD3bx+C2JhgHhs1l2ofbWE8=;
	b=yJx47qRoRxfSJL+SEtnd9kL523fh6rQFdldjrlLnzCLYkUQWZ3EaTqT5RdEqs5QWWMyuk5
	tYjpxsJJmx5PR1Cw==
To: Charlie Jenkins <thecharlesjenkins@gmail.com>, Xiaofeng Yuan
 <xiaofengmian@163.com>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] riscv: probes: simulate c.jal instruction
In-Reply-To: <178253409654.105999.9483335947060007692.b4-review@b4>
References: <20260627001939.3847-1-xiaofengmian@163.com>
 <178253409654.105999.9483335947060007692.b4-review@b4>
Date: Sat, 27 Jun 2026 12:59:50 +0200
Message-ID: <878q805jvd.fsf@yellow.woof>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

Charlie Jenkins <thecharlesjenkins@gmail.com> writes:
> I was looking at this recently trying to figure out why this hadn't been
> implemented and couldn't determine why this one was special, it might be
> because it is 32-bit only.

Yes. When I looked into this, I had no idea how to test rv32, so I skipped it.

> Since it is 32-bit only, can you put ifdefs
> around it for riscv32 (#if __riscv_xlen == 32) ?

Except for slightly bigger kernel size, it does not hurt to keep. And
#if stuff is quite ugly. But I'm fine with it either way.

> Can you also add a test case to:
> arch/riscv/kernel/tests/kprobes/test-kprobes-asm.S?

I already have a patch adding test case. Let me send it.

Nam