From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FD438C2D6 for ; Fri, 3 Apr 2026 14:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775227418; cv=none; b=Z+Zw2pfFGz7ALvLPHgzNdsMxkkLAeUI8qWa1eCqmVkiIKxRAt2Op/u16whJJOc8NJDDOySxrSZaCMMsjkbTci5pRCAId6VY/jQkG6M4cA0jdgPW3vtR8N7XEF0SeumYiEBjEpDgTEi2o5SU4OnHeCoeXJbROQW5qnKRQ2hGS2Xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775227418; c=relaxed/simple; bh=p6TlnwXXMOEwD+PT+buCKlICS0LcUWK9btaND47FJ/s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gsxoFjcwYTxpfX7GR7zK6o5DGHc16C1+WOq587MtLIdbAOz3cqpHufMhxPCIyW6bDrlrrQg9g+mrYMd3RkBmaoGQBtspovPAoXlmKnEhP94hfJ8zpM8bOgb5XzCI+j2Swd75mJVaBCtycmQxBkCHYTb73dwWsDg4O2Pg10pe+QY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KY0BC+/9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KY0BC+/9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A946C4CEF7; Fri, 3 Apr 2026 14:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775227417; bh=p6TlnwXXMOEwD+PT+buCKlICS0LcUWK9btaND47FJ/s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KY0BC+/9kpLA4OvyHbSA36gHMj4lUOYYcBO6QRxsEUlQgCC0tnStFDbnqdnHCKvHU HRwgu/EahRIkj+kiKpr+aWmB10xIqdf4IZ7ZgznQ1RNEQjYscjyZo/f6BVSiQ59EKv 8fHGaJLgFh9VglrreGwgN7lH4400NQHDo85Xx/xqZ0j7iWTydVEai09TMva0tlJrRz rVHwL9VKaHZJ9jbZTY07JIlA5aGa8s43aWBzeskxQELj373+toXZ3ZxKo7LvUNli+x YV0vpSISW833pJsCC81eVZ4l++Acmr9Sy1xWC1fMTHp0nyosOBOQuN/Ampr6c+GIYX lFfSpiJDYVXFw== From: Thomas Gleixner To: Peter Zijlstra Cc: Borislav Petkov , Calvin Owens , Petr Mladek , linux-kernel@vger.kernel.org, arighi@nvidia.com, yaozhenguo1@gmail.com, tj@kernel.org, feng.tang@linux.alibaba.com, lirongqing@baidu.com, realwujing@gmail.com, hu.shengming@zte.com.cn, dianders@chromium.org, joel.granados@kernel.org, Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker , Anna-Maria Behnsen , x86@kernel.org Subject: Re: [PATCH] clockevents: Prevent timer interrupt starvation In-Reply-To: <20260403121648.GZ3738010@noisy.programming.kicks-ass.net> References: <87v7ejetl1.ffs@tglx> <875x6a913n.ffs@tglx> <20260401163435.GGac1JG42tWmsCKL37@fat_crate.local> <87jyup70ka.ffs@tglx> <20260403121648.GZ3738010@noisy.programming.kicks-ass.net> Date: Fri, 03 Apr 2026 16:43:34 +0200 Message-ID: <878qb46r55.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Apr 03 2026 at 14:16, Peter Zijlstra wrote: >> delta = ktime_to_ns(ktime_sub(expires, ktime_get())); >> + >> + /* Don't reprogram when a forced event is pending */ >> + if (dev->next_event_forced && delta <= (int64_t)dev->min_delta_ns) >> + return 0; >> + >> if (delta <= 0) >> return force ? clockevents_program_min_delta(dev) : -ETIME; >> > > This last hunk seems duplicate of the clockevents_program_min_delta() > change, that also will bail when next_event_forced is set. Yeah. I was planning to look into it with brain awake today again. > Also, I note, thing (except shutdown) will ever clear next_event_forced; > and I'm thinking that any interrupt or normal reprogram should be doing > that. See my reply to Calvin. :)