Re: [PATCH] spi: cadence-qspi: Fix requesting of APB and AHB clocks on JH7110

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hello,

On 07/03/2026 at 09:50:35 GMT, Mark Brown <broonie@kernel.org> wrote:

> The move of the AHB and APB clocks from a JH7110 specific quirk to the
> main clock init dropped the specification of the clock names to request
> for the AHB and APB clocks, resulting in the clock framework requesting
> a clock with a NULL name three times.  On most platforms where the
> clocks are physically the same or some are always on this makes no
> difference but the reason we had the specific quirk for JH7110 is that
> it does actually have separate, controllable clocks.  Update the new
> code to request the AHB and APB clocks by name to restore the original
> behaviour on JH7110.

I know I'm late, but I wanted to understand what was wrong. Clearly I
misunderstood the clk bulk API. It only works with names, not indexes,
and I didn't got that right when I proposed the switch. The fix from
Mark is correct (thanks). The RZ/N1 platform was also only getting a
single clock instead of two, but the one it was getting is derived from
the other, so in turns both were enabled.

It eventually makes sense. Thanks Mark.

Miquèl