From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD43394460 for ; Wed, 4 Feb 2026 08:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770194042; cv=none; b=E3f0q9WtAmRZqy6S7yJ279/Xwg/eI/uEacGpzGbdlB0BT9KXTByE/BzG4hIQs7iq+QzPQgOqGljGI2kmAaxzbAUIb9eRCbgqqe9Jx/A64AcDLpWYpEQfqHVKr7X/Ii4gsoCWvr3m/02LhuOIDFEtnqbEe1i9NHfJEwYmr94zmMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770194042; c=relaxed/simple; bh=jU5XUIh7qVqt1sNUIHOcERIDnddZF1LxnSDFOqNZfuA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=nmnnqA8QclfCbHPcTARzMF0D9AsY0dN5wwHZObI0jVzUW5lw2hs3HlSuu/gTca5clGEJ17S+9xC59ohZfD3I6XeElFT5QkV8M0bdXuqaSxGoXcuMjgKBwNcM1w2lE1Czw2Ew4aYLsXnbfJtSPRlX3t+HRD15SMPVgS3AOyHT4qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=SycNVSkp; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="SycNVSkp" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E040EC24391; Wed, 4 Feb 2026 08:34:05 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 51B6F60745; Wed, 4 Feb 2026 08:34:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9468E119A865B; Wed, 4 Feb 2026 09:33:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770194039; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=jU5XUIh7qVqt1sNUIHOcERIDnddZF1LxnSDFOqNZfuA=; b=SycNVSkpMox2GZw+VUtazXmr99r7RBfMPX2qbNICLIyAdULdXws1QGwjsFZk7MzCM4KHf8 7f+Ls934Gx0knfKnFms+Ivb/q5d9zahuB5iaok1cIcDrQGNJT9x7F/fPp3jSp8syonmcGI C6XfkSOj87kbeBCWJLnDRPMQW5FoWg5eX1d1z8h6mwoWd5ZPbvk810qfuFwV0DFhhnbxeN sM1ll5DTqemkQ4zFrPHEU5g84jSvRFWInoBia7lrFBpHkuzgGqDfOHRDPN9vnFFgavZrpm YfwbI0Gkx/Fir0IyEylRQsnF42ixvtJKBHh+ZUMH2MCj1sbA4BFxmxXeS4DL9Q== From: Miquel Raynal To: Cheng Ming Lin Cc: Vignesh Raghavendra , Richard Weinberger , Tudor Ambarus , Martin Kurbanov , Mikhail Kshevetskiy , Pratyush Yadav , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, Cheng Ming Lin Subject: Re: [PATCH v4 1/2] mtd: spi-nand: Add support for randomizer In-Reply-To: (Cheng Ming Lin's message of "Wed, 4 Feb 2026 09:47:15 +0800") References: <20260203021358.693291-1-linchengming884@gmail.com> <20260203021358.693291-2-linchengming884@gmail.com> <87ecn1hovq.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 04 Feb 2026 09:33:54 +0100 Message-ID: <878qd8hpql.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Cheng Ming, >> Looking at the current implementation, I really don't like the core >> always calling in the "init" and the manufacturer driver reading the DT >> and deciding whether or not it enables it. > > I agree. I will refactor the logic in v5 so that the core parses the > generic DT properties (nand-enable-randomizer and > nand-disable-randomizer). > > Then, spinand_randomizer_init will determine the state and pass a > boolean argument to the set_randomizer callback, leaving the driver > to strictly handle the hardware configuration. Perfect. Thanks, Miqu=C3=A8l