From: Takashi Iwai <tiwai@suse.de>
To: Kriish Sharma <kriish.sharma2006@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Klimov <alexey.klimov@linaro.org>
Subject: Re: [PATCH] docs: sound: describe 'chan_map' member in snd_dec_opus
Date: Sat, 27 Sep 2025 10:17:34 +0200 [thread overview]
Message-ID: <878qi0b97l.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250926162658.989479-1-kriish.sharma2006@gmail.com>
On Fri, 26 Sep 2025 18:26:58 +0200,
Kriish Sharma wrote:
>
> When building kernel docs, the following warning appeared:
>
> WARNING: ./include/uapi/sound/compress_params.h:364 struct member 'chan_map' not described in 'snd_dec_opus'
>
> The inline struct 'snd_dec_opus_ch_map' inside 'snd_dec_opus' was not properly documented.
> This patch documents the 'chan_map' member and its fields (stream_count, coupled_count, channel_map), resolving the warning.
>
> Signed-off-by: Kriish Sharma <kriish.sharma2006@gmail.com>
Adding Alexey to Cc, as it was added by his patch.
If any, please resubmit with a proper subject line (e.g. "ALSA:
compress: ....") as well as the Fixes tag pointing to the affecting
commit.
thanks,
Takashi
> ---
> include/uapi/sound/compress_params.h | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> index faf4fa911f7f..e90e2f40732a 100644
> --- a/include/uapi/sound/compress_params.h
> +++ b/include/uapi/sound/compress_params.h
> @@ -336,16 +336,14 @@ struct snd_dec_ape {
> * @mapping_family: Order and meaning of output channels. Only values 0 and 1
> * are expected; values 2..255 are not recommended for playback.
> *
> - * Optional channel mapping table. Describes mapping of opus streams to decoded
> - * channels.
> - * @struct snd_dec_opus_ch_map
> - * @stream_count: Number of streams encoded in each Ogg packet.
> - * @coupled_count: Number of streams whose decoders are used for two
> - * channels.
> - * @channel_map: describes which decoded channel to be used for each one.
> - * See RFC doc for details.
> - * This supports only mapping families 0 and 1, therefore max
> - * number of channels is 8.
> + * @chan_map: Optional channel mapping table. Describes mapping of opus streams
> + * to decoded channels. Fields:
> + * - @stream_count: Number of streams encoded in each Ogg packet.
> + * - @coupled_count: Number of streams whose decoders are used
> + * for two channels.
> + * - @channel_map: Which decoded channel to be used for each one.
> + * Supports only mapping families 0 and 1,
> + * max number of channels is 8.
> *
> * These options were extracted from RFC7845 Section 5.
> */
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-09-27 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 16:26 [PATCH] docs: sound: describe 'chan_map' member in snd_dec_opus Kriish Sharma
2025-09-27 8:17 ` Takashi Iwai [this message]
2025-09-27 11:59 ` Bagas Sanjaya
[not found] ` <CAL4kbRMp912C+xqO4RYnGBO_VSqXJDSkNMgktd04zcUMOn_4-w@mail.gmail.com>
2025-09-27 13:03 ` Kriish Sharma
2025-09-27 13:48 ` Bagas Sanjaya
2025-09-27 11:50 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qi0b97l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexey.klimov@linaro.org \
--cc=kriish.sharma2006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox