From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D470E1946C8
	for <linux-kernel@vger.kernel.org>; Thu, 16 Jan 2025 09:16:37 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1737018999; cv=none; b=elilUq4/qQ0D2Y61TOFw3QRmfBkr1+63Pi+bOKLZNTkGIo1sDjzrgVn1VO8mnI5P1C4k4hSMKbaK0mW7uNbEUWxa0Sul+cRSZnWs+Vn6m+MYdfRRtgfHYkMOeJv8EPWlZDpiC5nQWRoyuDDb8e5Z202o0pHHxZXA5JYiFF3S71I=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1737018999; c=relaxed/simple;
	bh=Q9xmzoovgzWta9HUO5PpBRAcai3aaT3n3pL5aRG0mVw=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=ALazZAYn9ozhEP9zyK8TzgVObScL8oU0E64va9P1qcaAdJvhi+wtkYx8EurHPgFWrYRM2IadbKrF39SjKo6NRIzysqJ8RsXIc5YKvHS3h6y7C0lgSTqwC1i9dVsG+QUnfo+oy4aWtSBjQckfG5iBEi/Q6UHmR8HnMN5ulAeiHn0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=IRX9CeZi; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ryZlwvnG; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="IRX9CeZi";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ryZlwvnG"
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1737018989;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=dR9d8hq2jQ3Md5+DAG2hY3ccHNuphj7ozKvon0AQgiE=;
	b=IRX9CeZi1Dy1CmLOaV2a5zxoSt29gZV0h3YmxlCgE/QnJCdTJYEW6cTQnjk+YxJzq6Stbc
	wmcs1SEg7ijjkCFKTfXnMIn/m5M6RWt67iMBd9o4tgncDzkcWZXAr8hRS/28kpChmJ7U89
	mzU1ylJMUTa1sl2GTnFjO0pHzozscu3RjwTmx9XL3Zg+oiby6d2D3UW3KWlFAv+TGjgpI/
	6ntKi5374jeh6n6kbtNz50UcamJBj4hG6yaZq2rcIEa+s5WXAuEVGM4C07xHQdMruMAEBM
	TZTJnEEVF1AwGsXG0D84+0y2OCnqV6nC0zEkDjvsWEnX22rtvpUxf5WuYGW1FQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1737018989;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=dR9d8hq2jQ3Md5+DAG2hY3ccHNuphj7ozKvon0AQgiE=;
	b=ryZlwvnGWC4A3ozCSxRD+wWlZ0k6G6obaBBGHwUGWbpTM4omCnWmayxs/O2GRy609cieSE
	WcIpsQni8W935TDg==
To: Koichiro Den <koichiro.den@canonical.com>, linux-kernel@vger.kernel.org
Cc: anna-maria@linutronix.de, frederic@kernel.org, peterz@infradead.org
Subject: Re: [PATCH] hrtimer: reset .hres_active and .online at appropriate
 points
In-Reply-To: <20241220134421.3809834-1-koichiro.den@canonical.com>
References: <20241220134421.3809834-1-koichiro.den@canonical.com>
Date: Thu, 16 Jan 2025 10:16:29 +0100
Message-ID: <878qrbazki.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Dec 20 2024 at 22:44, Koichiro Den wrote:
> Reset these fields at the appropriate points. Ideally, .hres_active
> would be reset in tick_cpu_dying() as underlying clockevent is shut down
> there. However, since these operations occur in the atomic AP section
> with interrupts disabled in any case, this patch resets .hres_active to
> 0 in hrtimers_cpu_dying() for simplicity.

It does not matter where it is reset and from a hrtimer point of view
the dying() callback is the appropriate place.

Thanks,

        tglx