public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: 胡连勤 <hulianqin@vivo.com>
Cc: "perex@perex.cz" <perex@perex.cz>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"lina@asahilina.net" <lina@asahilina.net>,
	"mbarriolinares@gmail.com" <mbarriolinares@gmail.com>,
	"wangdicheng@kylinos.cn" <wangdicheng@kylinos.cn>,
	"cyan.vtb@gmail.com" <cyan.vtb@gmail.com>,
	"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
	"bsevens@google.com" <bsevens@google.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Add delay quirk for USB Audio Device
Date: Wed, 15 Jan 2025 09:02:11 +0100	[thread overview]
Message-ID: <878qrcld30.wl-tiwai@suse.de> (raw)
In-Reply-To: <TYUPR06MB6217F6DFCF671E7B0E001D9ED2192@TYUPR06MB6217.apcprd06.prod.outlook.com>

On Wed, 15 Jan 2025 07:45:33 +0100,
胡连勤 wrote:
> 
> From: Lianqin Hu <hulianqin@vivo.com>
> 
> Audio control requests that sets sampling frequency sometimes fail on
> this card. Adding delay between control messages eliminates that problem.
> 
> Signed-off-by: Lianqin Hu <hulianqin@vivo.com>

Could you give a bit more specific name / model to both the subject
and the quirk comment?  Then it'd be more helpful for people who read
/ check the changes later.


thanks,

Takashi


> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 8ba0aff8be2e..7968d6a2f592 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2239,6 +2239,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x0c45, 0x6340, /* Sonix HD USB Camera */
>  		   QUIRK_FLAG_GET_SAMPLE_RATE),
> +	DEVICE_FLG(0x0d8c, 0x0014, /* USB Audio Device */
> +		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x0ecb, 0x205c, /* JBL Quantum610 Wireless */
>  		   QUIRK_FLAG_FIXED_RATE),
>  	DEVICE_FLG(0x0ecb, 0x2069, /* JBL Quantum810 Wireless */
> -- 
> 2.39.0
> 

  reply	other threads:[~2025-01-15  8:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15  6:45 [PATCH] ALSA: usb-audio: Add delay quirk for USB Audio Device 胡连勤
2025-01-15  8:02 ` Takashi Iwai [this message]
2025-01-15  8:30   ` 答复: " 胡连勤
2025-01-15  8:41     ` Takashi Iwai
2025-01-15  8:46       ` 答复: " 胡连勤

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qrcld30.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=bsevens@google.com \
    --cc=cyan.vtb@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=hulianqin@vivo.com \
    --cc=lina@asahilina.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mbarriolinares@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=wangdicheng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox