public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Neal Gompa <neal@gompa.dev>,
	Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, patches@lists.linux.dev,
	Sami Tolvanen <samitolvanen@google.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	tech-board@groups.linuxfoundation.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by
Date: Sun, 12 Jan 2025 12:59:23 -0700	[thread overview]
Message-ID: <878qrfdcro.fsf@trenco.lwn.net> (raw)
In-Reply-To: <CAEg-Je9Cs54SkvhzbSq=2v2QYMo=mwUuGqFcs6cvi7nFgw6+Ug@mail.gmail.com>

Neal Gompa <neal@gompa.dev> writes:

> I've had my Reviewed-by tags silently ignored or deliberately stripped
> because even though I've done a technical review, the maintainer does
> not believe that I did. Therefore, what I am saying is that
> maintainers seem to speciously decide whether an Acked-by or
> Reviewed-by tag is appropriate or not *after* someone has sent it.
>
> This is the fundamental problem I have right now. This decision is not
> the maintainer's to make, it is the submitter's.

There *are* people who seem to make a game of getting as many such tags
into the repository as possible.  I think a bit of maintainer discretion
is important here; I don't believe that there is a fundamental right to
inject a tag into somebody else's patch...?

jon

  parent reply	other threads:[~2025-01-12 19:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-12 15:29 [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Miguel Ojeda
2025-01-12 15:29 ` [PATCH 1/3] docs: submitting-patches: clarify Acked-by and introduce "# Suffix" Miguel Ojeda
2025-01-12 15:52   ` Neal Gompa
2025-01-12 17:24   ` Greg Kroah-Hartman
2025-01-13 11:52   ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by Miguel Ojeda
2025-01-12 15:50   ` Neal Gompa
2025-01-12 16:31     ` Miguel Ojeda
2025-01-12 16:35       ` Neal Gompa
2025-01-12 17:10         ` Miguel Ojeda
2025-01-12 19:59         ` Jonathan Corbet [this message]
2025-01-12 20:13           ` Neal Gompa
2025-01-13 14:13         ` Theodore Ts'o
2025-01-13 11:48     ` Krzysztof Kozlowski
2025-01-13 12:38     ` Jani Nikula
2025-01-13 15:15       ` Steven Rostedt
2025-01-14 23:13     ` Darrick J. Wong
2025-01-12 17:25   ` Greg Kroah-Hartman
2025-01-13 11:50   ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags Miguel Ojeda
2025-01-12 15:47   ` Neal Gompa
2025-01-12 16:33     ` Miguel Ojeda
2025-01-12 17:24     ` Greg Kroah-Hartman
2025-01-13 13:36     ` Mark Brown
2025-01-13 14:22     ` Theodore Ts'o
2025-01-13 15:36       ` Steven Rostedt
2025-01-12 17:22   ` Greg Kroah-Hartman
2025-01-13 11:51   ` Krzysztof Kozlowski
2025-01-13 17:47 ` [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qrfdcro.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=djwong@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=neal@gompa.dev \
    --cc=ojeda@kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=samitolvanen@google.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tech-board@groups.linuxfoundation.org \
    --cc=torvalds@linux-foundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox