From: Andreas Hindborg <a.hindborg@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
linux-kbuild@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH 2/3] kbuild: rust: apply `CONFIG_WERROR` to all Rust targets
Date: Fri, 10 Jan 2025 14:33:02 +0100 [thread overview]
Message-ID: <878qrig5f5.fsf@kernel.org> (raw)
In-Reply-To: <CAK7LNAQkUik_VW7j-d56Pr4NnExxDnjMfWSwtxvijH4q4Onctg@mail.gmail.com> (Masahiro Yamada's message of "Wed, 22 May 2024 20:58:46 +0900")
Masahiro Yamada <masahiroy@kernel.org> writes:
> On Wed, May 22, 2024 at 7:52 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>>
>> On Wed, May 22, 2024 at 12:14 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>> >
>> > What does "everything else" mean exactly?
>>
>> Everything but the host programs. Or as many targets as possible, if
>> you think there are other cases that we should avoid.
>
>
> You can do this if rebuilding makes sense
> when any CONFIG option is changed.
Not having the ability to make builds fail when clippy or rustdoc is
issuing warnings is a big problem. I would very much like to have the
option to make builds fail when these targets give warnings.
@Miguel: Should I look into exempting host programs, or do you already
have an idea of how to implement?
Regarding host programs, it would be nice to set werror for those. How
does C do this? Is W=e enough?
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-01-10 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-19 21:12 [PATCH 1/3] kbuild: rust: move `-Dwarnings` handling to `Makefile.extrawarn` Miguel Ojeda
2024-05-19 21:12 ` [PATCH 2/3] kbuild: rust: apply `CONFIG_WERROR` to all Rust targets Miguel Ojeda
2024-05-20 9:43 ` Alice Ryhl
2024-05-21 4:14 ` Masahiro Yamada
2024-05-21 8:05 ` Miguel Ojeda
2024-05-22 10:13 ` Masahiro Yamada
2024-05-22 10:52 ` Miguel Ojeda
2024-05-22 11:58 ` Masahiro Yamada
2025-01-10 13:33 ` Andreas Hindborg [this message]
2025-01-12 18:32 ` Miguel Ojeda
2025-01-10 13:27 ` Andreas Hindborg
2024-05-19 21:12 ` [PATCH 3/3] kbuild: rust: support `W=e` for Rust Miguel Ojeda
2024-05-20 9:44 ` Alice Ryhl
2025-01-10 13:28 ` Andreas Hindborg
2024-05-20 9:41 ` [PATCH 1/3] kbuild: rust: move `-Dwarnings` handling to `Makefile.extrawarn` Alice Ryhl
2025-01-10 13:12 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qrig5f5.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox