From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98F7D1DE889 for ; Mon, 28 Oct 2024 18:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730138713; cv=none; b=hEtOzFJ8EiBndRZ5d+zPu/a4VzBIGEJyhqf3cz142V6pEmOHU4g8WWq/L4sb69xjaFHDUUQZpX3UxiTfTGrFeWvzV7icW3DkaEUp6l9k3EQx/0NGO7zDAXaLlkKQ4d71xQcsg0VLrpcnoDG1haAqJmEHuv+C6q36d9Rasr+ZCko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730138713; c=relaxed/simple; bh=fRlbN0InUEXs0zuP8f30G39Kp0WFE/xogpDAJIV2xMA=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cKezSmk8ng70tOWHf85q/pcpH7pyc2Idvu3Q8MvRC1Qf6keKGtxf8bb04FYOxhARtk9AaPLwihDZPY8dIifZkRfwCyMMubYHV/Vpp82S3Hhe8hat74A6mOn9Xp2HRoWbIHGQbnPpsC8wr5TSi3iFkbLMWul4MzfYVAhkXy0siwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Wqnz5mGb; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ILAs6NsC; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Wqnz5mGb"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ILAs6NsC" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1730138709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3IDfOXFVv8kBd1AWaPkUULk3ghdxFNcDz4iKI1BeRtc=; b=Wqnz5mGb7wOtrf9nVF/4H2cqx3QmYeROhop48+HP4GxGtvpocb2uj7sdq2yFVnZ0q9F29U S+JlT7AO5CpAf2L5/XQgWa7vy8CwvL2ez68664dVHWmz4p7h1OIzQH4PD6qiHCm6sYppXq uFWFycKuH4BjHl0raEvghxhP6NtizoqCpMKn44SzdcZdUHk1XYSwf2zXtP5r7hBBPW/liA 3yST+e+jmLJ17SHvFHgwCqTjCO7bPf5tLX1ThjGlRpTdbHRqI0m3IbHEEHTjE6YLUkOXyp 4nPqYOMVhjxyoEe4OcupaaxSruikYjaCRWn+RiUUeaKIB81qxZ6PcG/HqJqZBA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1730138709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3IDfOXFVv8kBd1AWaPkUULk3ghdxFNcDz4iKI1BeRtc=; b=ILAs6NsCraYSC6mSWPKyHlbMSkWOol2nsWAsk/dQyIBpFI0D369S7UBifZ1p1UghPbvNKc Xvv8KS2I+za31LBg== To: Jinjie Ruan , oleg@redhat.com, linux@armlinux.org.uk, will@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, sstabellini@kernel.org, maz@kernel.org, peterz@infradead.org, luto@kernel.org, kees@kernel.org, wad@chromium.org, akpm@linux-foundation.org, samitolvanen@google.com, arnd@arndb.de, ojeda@kernel.org, rppt@kernel.org, hca@linux.ibm.com, aliceryhl@google.com, samuel.holland@sifive.com, paulmck@kernel.org, aquini@redhat.com, petr.pavlu@suse.com, ruanjinjie@huawei.com, viro@zeniv.linux.org.uk, rmk+kernel@armlinux.org.uk, ardb@kernel.org, wangkefeng.wang@huawei.com, surenb@google.com, linus.walleij@linaro.org, yangyj.ee@gmail.com, broonie@kernel.org, mbenes@suse.cz, puranjay@kernel.org, pcc@google.com, guohanjun@huawei.com, sudeep.holla@arm.com, Jonathan.Cameron@huawei.com, prarit@redhat.com, liuwei09@cestc.cn, dwmw@amazon.co.uk, oliver.upton@linux.dev, kristina.martsenko@arm.com, ptosi@google.com, frederic@kernel.org, vschneid@redhat.com, thiago.bauermann@linaro.org, joey.gouly@arm.com, liuyuntao12@huawei.com, leobras@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH -next v4 15/19] entry: Add arch irqentry_exit_need_resched() for arm64 In-Reply-To: <20241025100700.3714552-16-ruanjinjie@huawei.com> References: <20241025100700.3714552-1-ruanjinjie@huawei.com> <20241025100700.3714552-16-ruanjinjie@huawei.com> Date: Mon, 28 Oct 2024 19:05:09 +0100 Message-ID: <878qu82je2.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Oct 25 2024 at 18:06, Jinjie Ruan wrote: > As the front patch 6 ~ 13 did, the arm64_preempt_schedule_irq() is Once this series is applied nobody knows what 'front patch 6 ~ 13' did. > same with the irq preempt schedule code of generic entry besides those > architecture-related logic called arm64_irqentry_exit_need_resched(). > > So add arch irqentry_exit_need_resched() to support architecture-related > need_resched() check logic, which do not affect existing architectures > that use generic entry, but support arm64 to use generic irq entry. Simply say: ARM64 requires an additional whether to reschedule on return from interrupt. Add arch_irqentry_exit_need_resched() as the default NOOP implementation and hook it up into the need_resched() condition in raw_irqentry_exit_cond_resched(). This allows ARM64 to implement the architecture specific version for switchting over to the generic entry code. That explains things completely independently. Hmm? Thanks, tglx