* [PATCH] kbuild: deb-pkg: fix building with bindeb-pkg
@ 2024-07-14 10:34 Bert Karwatzki
2024-07-14 10:50 ` Andreas Schwab
0 siblings, 1 reply; 2+ messages in thread
From: Bert Karwatzki @ 2024-07-14 10:34 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Bert Karwatzki, linux-kernel
Since the introduction of "set -u" into scripts/package/mkdebian running
the mkdebian scripts fails when it is called with no arguments (which is
the case when building the kernel with 'make bindeb-pkg'). This patch
introduces an additional check so mkdebian can be run without arguments.
Fixes: 8ef052389f7f ("kbuild: package: add -e and -u options to some shell scripts")
Signed-off-by: Bert Karwatzki <spasswolf@web.de>
---
scripts/package/mkdebian | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index 196b14e8ad47..5eb506573a4d 100755
--- a/scripts/package/mkdebian
+++ b/scripts/package/mkdebian
@@ -135,7 +135,7 @@ else
fi
maintainer="${name} <${email}>"
-if [ "$1" = --need-source ]; then
+if [ $# -eq 1 ] [ "$1" = --need-source ]; then
gen_source
fi
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kbuild: deb-pkg: fix building with bindeb-pkg
2024-07-14 10:34 [PATCH] kbuild: deb-pkg: fix building with bindeb-pkg Bert Karwatzki
@ 2024-07-14 10:50 ` Andreas Schwab
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Schwab @ 2024-07-14 10:50 UTC (permalink / raw)
To: Bert Karwatzki; +Cc: Masahiro Yamada, linux-kernel
On Jul 14 2024, Bert Karwatzki wrote:
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index 196b14e8ad47..5eb506573a4d 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -135,7 +135,7 @@ else
> fi
> maintainer="${name} <${email}>"
>
> -if [ "$1" = --need-source ]; then
> +if [ $# -eq 1 ] [ "$1" = --need-source ]; then
[: too many arguments
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-14 10:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-14 10:34 [PATCH] kbuild: deb-pkg: fix building with bindeb-pkg Bert Karwatzki
2024-07-14 10:50 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox