From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A8071B977; Sat, 24 Feb 2024 11:31:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708774269; cv=none; b=pzgKj67CnwbEtT/gRykQ9NcOexXhks81Sw3ZAQ8MmgIKXzBBqw9Y+CvZFDc+m9OJrEwG9OEPZi1Nnr+yVWQJKTFiwt5sdQi/W7OLmYKXRTALzGgMnISFqsMXMTWcPRQqLsWgQ189KLRrOTfRO5Apmfn31sU+Nr9DIuwDcklaLvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708774269; c=relaxed/simple; bh=bcm3DdqghLXqV1NDYxNhc4E3ZjWsODb7HUSJWc8HasI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=hYqbLzB0s/PsqWimPqVEW+rI0fS8l/gfYMrU+1YYoo5nTLcPozPGb5DUGHhhpdLZdNk/FoIvRW15RZDYakDQKA99rp9nDJ4F+che8w8EcwwE17ECMhr769myzpMJOp0ZqjkxAS+Mp41LfXkPo0lphtaBOT4/2Ku1zKe0Gj8RQ2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qBoXj187; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qBoXj187" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9E56C433C7; Sat, 24 Feb 2024 11:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708774268; bh=bcm3DdqghLXqV1NDYxNhc4E3ZjWsODb7HUSJWc8HasI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qBoXj187P+E9luvr9Axsx9150L4De7EaN940cIVttWMr7c7jJL8NXQgF8/raWWXNl Eq/F4upq5KMG93mJLniOyY0Je2IXCLhD7wNx/1VnJB/9hPIngT+tkA/qzhHoDfpmVR XTAfZm9tHemT/6HM+4nr34cEq8HHy7/iL8H9TSh8WiHSvhz121huf7QADtQbDrIU29 KjGqs7oUnoAV2bnIgsQgJ2ya7XEIILD9abEaTYa+a64uSce8Cdix5fvOwPGJLqfL7E vzZH420bTizVHF6dPO8NqgrsWdVwafztNrTkORK2q0GU4dRwU/ICGWOxFXnbfgkRsX 7ToAAzBRglDcw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rdqFG-006M9n-Jj; Sat, 24 Feb 2024 11:31:06 +0000 Date: Sat, 24 Feb 2024 11:31:05 +0000 Message-ID: <878r3a9k06.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: Thomas Gleixner , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, Jing Zhang Subject: Re: [PATCH 3/3] irqchip/gic-v3-its: Print the vPE table installed in redistributor In-Reply-To: References: <20240219185809.286724-1-oliver.upton@linux.dev> <20240219185809.286724-4-oliver.upton@linux.dev> <87bk869man.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, tglx@linutronix.de, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, jingzhangos@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 24 Feb 2024 11:11:41 +0000, Oliver Upton wrote: > > On Sat, Feb 24, 2024 at 10:41:36AM +0000, Marc Zyngier wrote: > > On Mon, 19 Feb 2024 18:58:08 +0000, Oliver Upton wrote: > > > - pr_debug("CPU%d: VPROPBASER = %llx %*pbl\n", > > > - smp_processor_id(), val, > > > - cpumask_pr_args(gic_data_rdist()->vpe_table_mask)); > > > + pr_info("CPU%d: Using %s vPE table @%llx (%s)\n", > > > + smp_processor_id(), > > > + (val & GICR_VPROPBASER_4_1_INDIRECT) ? "indirect" : "direct", > > > + val & GICR_VPROPBASER_4_1_ADDR, > > > + (page) ? "allocated" : > > > + ((from_its) ? "inherited from ITS" : "inherited from RD")); > > > > From past experience, having the vpe_table_mask value displayed did > > help tracking VPE table affinity bugs. > > My reasoning behind it was that the change expanded the table mask by > way of printing what's going on at every RD. But easy enough to throw > back in! Yeah, true enough. But the mask presents a nice, concise way to express the affinities that comparing a bunch of lines doesn't exactly convey. > > > This said, my problem with this patch is that we already have tons of > > these statement printed once per CPU/RD. This is really huge and > > accounts for a significant part of the boot time on large machines > > (64+ CPUs). > > > > Before we add more of those, I'd really want to have a way to tone > > them down and only print them at runtime *if* required by the user. > > Kind of a dymanic debug, but driven from the command-line and present > > early enough. > > Yeah, what'd be really nice is a way to enable pr_debug() on a per > file / driver / whatever basis, since turning on all of it becomes a bit > of a firehose... But I guess that's what grep is for. > > WDYT about leaving it at pr_debug() for now, with the additional context > of what exactly VPROPBASE is getting programmend with? Yup, I'm all for that. Hopefully we can find a good way to way to control the debug output in the near future. Thanks, M. -- Without deviation from the norm, progress is not possible.