From: John Ogness <john.ogness@linutronix.de>
To: Yicong Yang <yangyicong@huawei.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
tony@atomide.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com, tglx@linutronix.de,
yangyicong@hisilicon.com, linuxarm@huawei.com,
prime.zeng@hisilicon.com, jonathan.cameron@huawei.com,
fanghao11@huawei.com
Subject: Re: [PATCH] serial: port: Don't suspend if the port is still busy
Date: Mon, 05 Feb 2024 09:53:05 +0106 [thread overview]
Message-ID: <878r3zpaba.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20240204031957.58176-1-yangyicong@huawei.com>
On 2024-02-04, Yicong Yang <yangyicong@huawei.com> wrote:
> diff --git a/drivers/tty/serial/serial_port.c b/drivers/tty/serial/serial_port.c
> index 88975a4df306..60d1eec6b6b7 100644
> --- a/drivers/tty/serial/serial_port.c
> +++ b/drivers/tty/serial/serial_port.c
> @@ -46,8 +46,28 @@ static int serial_port_runtime_resume(struct device *dev)
> return 0;
> }
>
> +static int serial_port_runtime_suspend(struct device *dev)
> +{
> + struct serial_port_device *port_dev = to_serial_base_port_device(dev);
> + struct uart_port *port;
> + unsigned long flags;
> +
> + port = port_dev->port;
> +
> + if (port->flags & UPF_DEAD)
> + return 0;
> +
> + spin_lock_irqsave(&port->lock, flags);
> + if (__serial_port_busy(port))
> + pm_request_resume(dev);
> + spin_unlock_irqrestore(&port->lock, flags);
Please use the wrapper functions for the uart port lock:
uart_port_lock_irqsave()
uart_port_unlock_irqrestore()
John Ogness
next prev parent reply other threads:[~2024-02-05 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 3:19 [PATCH] serial: port: Don't suspend if the port is still busy Yicong Yang
2024-02-05 6:51 ` Tony Lindgren
2024-02-05 8:55 ` Yicong Yang
2024-02-05 9:07 ` Tony Lindgren
2024-02-06 8:02 ` Yicong Yang
2024-02-05 8:47 ` John Ogness [this message]
2024-02-05 9:00 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r3zpaba.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fanghao11@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox